-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add img role in all svg images to improve accessibility. #4130
Add img role in all svg images to improve accessibility. #4130
Comments
I would like to take this. If it's available |
can i work on this pls |
Hi @Angamanga I'd love to work on this. Thank you! |
@renujain31 can I work on this? I'm an outreachy applicant! |
@Angamanga please let me work on this issue. I'm Amadikwa Joy N. an outreachy applicant |
@AishaSaman @amycruz97 you already have a ticket assigned. Let us know (in the corresponding ticket) if you are blocked. Thanks. |
Thanks so much @rowasc , I've raised a PR for this issue here : ushahidi/platform-client#1593 |
This woman ehn😂😂😂 |
@karenefereyan I have no idea what you intend with this comment, can you explain? |
She sent in the PR minutes after she was assigned. It was so fast. That's what i mean |
@all-contributors please add @bukolabisuga for code |
I've put up a pull request to add @bukolabisuga! 🎉 |
Description:
When using embedded SVG images, it is a good idea to set role="img" on the outer element and give it a label.
This will cause screen readers to just consider it as a single entity and describe it using the label, rather than trying to read out all the child nodes.
Todo:
Search for
<svg class="iconic"
in the *.html files of platform-client codebase and replace it with<svg class="iconic" role="img"
. It involves changes at approximately 260 lines and 79 files so make sure that the UI is not affected.Aha! Link: https://ushahiditeam.aha.io/features/PROD-879
The text was updated successfully, but these errors were encountered: