Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invariant reducing function #119

Closed
ianhbell opened this issue Apr 13, 2024 · 1 comment
Closed

Fix invariant reducing function #119

ianhbell opened this issue Apr 13, 2024 · 1 comment
Labels
bug Something isn't working
Milestone
0.20.0

Comments

@ianhbell
Copy link
Collaborator

It was implemented assuming mixture is a binary mixture (as in Eq. 7.171 in GERG-2004), but that is wrong, and it should have implemented Eq. 5.18 from GERG-2004.
@ianhbell ianhbell added the bug Something isn't working label Apr 13, 2024
@ianhbell ianhbell added this to the 0.20.0 milestone May 9, 2024
@ianhbell
Copy link
Collaborator Author

ianhbell commented May 9, 2024

Closed by 522f3c9

@ianhbell ianhbell closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.20.0
Development

No branches or pull requests
1 participant
@ianhbell