Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/test virial coefficients for all models #140

Closed
ianhbell opened this issue Jul 16, 2024 · 1 comment · Fixed by #143
Closed

Fix/test virial coefficients for all models #140

ianhbell opened this issue Jul 16, 2024 · 1 comment · Fixed by #143
Labels
bug Something isn't working
Milestone

Comments

@ianhbell
Copy link
Collaborator

Due to a problem with autodiff (autodiff/autodiff#351) some virial coefficient calculations are incorrect when you have terms like pow(rho, int) and rho is evaluated at zero. Thus all models should have their virial coefficients compared with a calculation at a very low, but nonzero, density

@ianhbell ianhbell added the bug Something isn't working label Jul 19, 2024
@ianhbell
Copy link
Collaborator Author

Actually a lot of models are hit by this bug. Many can be worked around with the use of powi instead of pow

@ianhbell ianhbell added this to the 0.21.0 milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant