Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve loading events by name vs. guid #182

Open
bitbrain opened this issue Dec 9, 2023 · 0 comments
Open

Improve loading events by name vs. guid #182

bitbrain opened this issue Dec 9, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@bitbrain
Copy link
Contributor

bitbrain commented Dec 9, 2023

Currently, loading events in this extension is done by 'guid' (default) but in the settings users can opt-in to load by event name instead. While this is useful, sometimes developers want to load events by GUID, but in specific cases we just want to look them up by name, e.g. when the name is dynamic based on situation:

pickup_sound.fmod_event_name = "event:/Voice/" + fmod_id + "/" + "Voice-" + fmod_id + "-PickUp"
tired_sound.fmod_event_name = "event:/Voice/" + fmod_id + "/" + "Voice-" + fmod_id + "-Yawn"

In this case, I want FMOD to load it by event, since I provided a valid event name.

Proposal: best effort solution to lookup event

Rather than forcing a 'load everything by GUID' vs. 'load everything by name', we can change this to be something like 'prefer loading by GUID' vs. 'prefer loading by name' in the settings:

  • in case only GUID is present (but not event name) it will attempt to load by GUID, independent of 'prefer' setting
  • in case only name is present (but not GUID) it will attempt to load by name, independent of 'prefer' setting
  • in case both GUID and name are present, it will load by preferred setting
@bitbrain bitbrain added the enhancement New feature or request label Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant