Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Consider changing /MD to /MT for Windows MSVC compilation #71

Open
2shady4u opened this issue Feb 4, 2021 · 2 comments
Open

Comments

@2shady4u
Copy link
Contributor

2shady4u commented Feb 4, 2021

I've had a user complain to me that the library wasn't working on actively crashing the game.
After a lot of back and forth, we figured out that it was because the proper MSVC libraries weren't installed.
Godot isn't able to check this, nor is it able to install the proper VC++ redistributables.

The VCRUNTIME140-dependency as seen in DependenciesGUI:
image

What is the proper solution for this issue?

How are you guys handling this issue?

@2shady4u
Copy link
Contributor Author

2shady4u commented Feb 4, 2021

After some discussion there seem to be 2 commonly used solutions:

  • Compile the libraries using the /MT-flag. For example, Godot itself uses this and thus doesn't have any external VCRUNTIME.DLL dependencies
  • Add a copy of the VCRUNTIME.DLL myself to the folder. For example, Blender uses this method.

Both have potential disadvantages/advantages as described here:
https://stackoverflow.com/questions/757418/should-i-compile-with-md-or-mt

@CedNaru
Copy link
Member

CedNaru commented Feb 4, 2021

For consistency, I think it's better to take the same option as Godot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants