Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enforce Conventional Commit style commit messages #282

Merged
merged 2 commits into from
Jun 22, 2018

Conversation

broofa
Copy link
Member

@broofa broofa commented Jun 21, 2018

Adds pre-commit check to insure commit messages conform to https://conventionalcommits.org/ .

This is necessary (or at least desirable) to insure the impact of every commit is reflected in the semver and CHANGELOG docs when standard-version command is run.

Note: 'Dropped support for node@0.12 in Travis tests due to typicode/husky#308 . We can add 0.12 test support back in if/when that bug is fixed, or it becomes a real issue, but it was EOL'ed almost two years ago. I'm okay telling anyone who cares to pin their uuid version to a prior release and go from there.

@broofa broofa requested review from defunctzombie and vvo June 21, 2018 21:25
@broofa broofa merged commit cc9a182 into master Jun 22, 2018
broofa added a commit that referenced this pull request Jun 22, 2018
* feat: enforce Conventional Commit style

* chore: drop node@0.12 from Travis tests
@broofa broofa deleted the conventional_commits branch June 22, 2018 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants