Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort: migrate from ouroboros to self_cell #4971

Closed
cakebaker opened this issue Jun 12, 2023 · 2 comments · Fixed by #4972
Closed

sort: migrate from ouroboros to self_cell #4971

cakebaker opened this issue Jun 12, 2023 · 2 comments · Fixed by #4972
Labels

Comments

@cakebaker
Copy link
Contributor

The author of ouroboros recommends in someguynamedjosh/ouroboros#88 to migrate to self_cell because of a fundamental soundness problem:

TL;DR: Ouroboros has a soundness problem. A fix has been attempted but it was also unsound. Currently the compiler does not actually produce unsound machine code, but it may begin doing so at any point in the future. Migrate code to use self_cell instead.

@cakebaker
Copy link
Contributor Author

In the meantime, there has been an update:

UPDATE: A fix has been implemented. 0.16.0+ is no longer unsound in the described way, but support for template parameters had to be cut in the process.

I don't know whether we want to keep using ouroboros by updating it (see #4978) or still switch to self_cell (see #4972).

@tertsdiepraam
Copy link
Member

tertsdiepraam commented Jun 15, 2023

It might also be worth checking if we can get rid of the self-references in general. There's nothing fundamentally about sort that would require self-references. However, that would be a much larger change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants