who: move from getopts to clap (#2124) #2138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clap
v3.0.0-beta.2
was needed instead of the latest stable2.33.3
in order to be able to useArg::visible_short_alias
.Otherwise the use of multiple short flags for the same option would have required an ugly work around with an additional
App::arg
for every short flag alias.Since all other ports use clap
2.33
, I'm unsure if it's okay to use a non stable Clap?There are other uutils that would benefit from
Arg::visible_short_alias
, e.g.rm -r
/rm -R
(#1834), etc.