Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add Android x86_64 #5843

Merged
merged 1 commit into from
Jan 31, 2024
Merged

ci: add Android x86_64 #5843

merged 1 commit into from
Jan 31, 2024

Conversation

cakebaker
Copy link
Contributor

This PR enables Android x86_64 in the CI/CD as suggested in #5821 and should be merged after it.

Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@sylvestre
Copy link
Contributor

More failure!

@cakebaker
Copy link
Contributor Author

Unfortunately yes :|

@cre4ture
Copy link
Contributor

cre4ture commented Jan 15, 2024

Do you have an idea why this android build is so unstable?
The emulator is configured for 2GB (2048MB) of RAM.
Can we test if increasing this to e.g. 8GB helps?
My phone has 12GB of RAM and I had sporadic errors in the build & test due to memory allocation errors.

@cre4ture
Copy link
Contributor

I started to look into the problem of why the android build is instable and how to improve.
I have one question: why is it running on a mac os runner? I read today that mac os the most expensive runner. Windows is next and linux would be the cheapest. So why is the android-runner a mac-runner?

@tertsdiepraam
Copy link
Member

I honestly don't know. Maybe you can find some explanation in the PR that introduced the Android CI?

@cakebaker
Copy link
Contributor Author

I think the original reason was that hardware acceleration was only available on macOS VMs: ReactiveCircus/android-emulator-runner#46 . According to ReactiveCircus/android-emulator-runner#46 (comment) this is no longer relevant and so it might be worth to try to switch to Linux.

@sylvestre
Copy link
Contributor

it was the same with the freebsd runner (running on mac first), it is now much better :)

@sylvestre sylvestre merged commit 99f923a into uutils:main Jan 31, 2024
59 of 62 checks passed
@sylvestre
Copy link
Contributor

let's take this patch anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants