TN-3324 robust handling of unsortable patient list attributes #4414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release v24.10.10
Address a stream of 400 errors (CSRF token is missing) related to saving patientlist table preferences. Cause: I think the error stemmed from when an ajax request was first made to retrieve patient data, which is precedes by a call to save table preferences, the document DOM was not ready (which includes the value of CSRF token in an hidden element) - hence the missing CSRF token error. Fix: To add check for DOM readiness before the request to save table preferences is made. --------- Co-authored-by: Amy Chen <clone@cesium.cirg.washington.edu>
achen2401
approved these changes
Oct 22, 2024
Addressed a number of warnings in the tests, and a few random non-repeatable failures. Tests look to be more stable again. This does include the elimination of "integration_tests" which used selenium to attempt some basic browser login and such verification tests. They are fragile, and of little use given our required test plan before any release.
pbugni
deleted the
feature/robust-handling-of-unsortable-PatientList-attributes
branch
pbugni
added a commit
that referenced
this pull request
Oct 24, 2024
pbugni
restored the
feature/robust-handling-of-unsortable-PatientList-attributes
branch
pbugni
deleted the
feature/robust-handling-of-unsortable-PatientList-attributes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.