Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting Create Website and Jupyter Book gh-pages deployment. #17

Closed
valentina-s opened this issue Jun 25, 2024 · 2 comments
Closed

Comments

@valentina-s
Copy link
Contributor

Currently, whichever deployment is last will take over gh-pages. We can think how to make it work during the tutorial. Could just set them deploy from separate branches: and keep the Jupyter Book on except when we want to show the Create Webpage Example. On the participants fork we should make sure they have the create website deployment active only, since they do not need to rerender the jupyterbook website. Any better way to do this? I can also show things from a fork, and keep the uwescience one intact.

@scottyhq
Copy link
Collaborator

Yes, currently GitHub's deploy-pages action is "atomic" so it's all or nothing and not possible to just create a subpage on top of existing content (see actions/deploy-pages#349)

For the tutorial I think it makes sense to show [.github/workflows/create_website.yml] on your fork to avoid overwriting the book (.github/workflows/create_website.yml)

You could add if: github.repository == 'uwescience/SciPy2024-GitHubActionsTutorial' under runs-on below to only deploy the book in this repository and not on participant forks:

jobs:
deploy-book:
runs-on: ubuntu-latest

@valentina-s
Copy link
Contributor Author

Switched to readthedocs for the webpage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants