Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zero values and omitted fields in requests #190

Open
asmahood opened this issue Oct 25, 2022 · 0 comments
Open

Allow zero values and omitted fields in requests #190

asmahood opened this issue Oct 25, 2022 · 0 comments

Comments

@asmahood
Copy link
Member

asmahood commented Oct 25, 2022

Description

With the move to Golang and the new server implementation, the current validation doesn't work perfectly well. One example of a pitfall with the current validation is that for "zero" values. For example, if you want to update a members paid status to false, if you were to specify this in the request as false the required validation tag will fail. We want something to ensure that the field is present in the request.

Approach

  • Change all required fields with allowed zero values to be pointers with the required tag

Related To

Blocked By

Blocks

@asmahood asmahood transferred this issue from uwpokerclub/developer-hub Jul 27, 2023
@asmahood asmahood transferred this issue from uwpokerclub/app Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant