Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromaticで毎回差分が出る原因の特定と対応 #267

Closed
takashi0602 opened this issue Jul 12, 2023 · 12 comments
Closed

chromaticで毎回差分が出る原因の特定と対応 #267

takashi0602 opened this issue Jul 12, 2023 · 12 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@takashi0602
Copy link
Member

takashi0602 commented Jul 12, 2023

概要

UIを変更していないのにも関わらず、毎回差分が出る。そのため原因の特定と対応を行う。
(画像に背景色つけるのがよくない??)

@takashi0602 takashi0602 self-assigned this Jul 12, 2023
@tyokinuhata tyokinuhata added the bug Something isn't working label Jul 12, 2023
@tyokinuhata tyokinuhata added this to the 2023/08 milestone Jul 12, 2023
@takashi0602 takashi0602 modified the milestones: 2023/08, 2023/07 Jul 19, 2023
@tyokinuhata tyokinuhata modified the milestones: 2023/07, 2023/08 Aug 9, 2023
@takashi0602 takashi0602 modified the milestones: 2023/08, 2023/09 Sep 4, 2023
@takashi0602
Copy link
Member Author

Chromaticのサポート(多分あったはず)に投げてみる

@takashi0602 takashi0602 modified the milestones: 2023/09, 2023/10 Oct 4, 2023
@takashi0602
Copy link
Member Author

サポートに問い合わせたので続報待ち。。。

@takashi0602
Copy link
Member Author

返信が来たので記載

Hey Takashi - Suki with Chromatic here!
It looks like you haven't ran a build for the main branch. Would you mind running a build for this branch and let me know if you're receiving an error?

やあ、タカシ - ChromaticのSukiです!
メインブランチのビルドがまだのようですね。このブランチのビルドを実行して、エラーが発生したら教えてもらえますか?

@takashi0602
Copy link
Member Author

ローカルで $ npx chromatic --project-token <your-project-token> を打ったら最新のになった。なんで更新されなかったのかは現在質問中。。。
ref: https://www.chromatic.com/docs/setup/#run-chromatic

@takashi0602
Copy link
Member Author

Hey Takashi - thanks for your patience!
Awesome to hear that the branch is finally reflecting as updated, that's great news! 🎉 Regarding your question of why this is happening, this could be a number of reasons. Would you mind sharing your GitHub Actions .yml config so I can see how you have your workflow set up?

yamlファイル見せてと言われたので、以下リンク送った
https://github.com/uyupun/official/blob/main/.github/workflows/deploy-chromatic.yml

@takashi0602
Copy link
Member Author

返信きてた、CIが悪さしてるらしい

Good news, Takashi - I was able to spot what the issue is!
It looks like you have main set as a branch to ignore in your workflow: https://github.com/uyupun/official/blob/54ced8f4e2f63b760d80523244ee2ee654646624/.github/workflows/deploy-chromatic.yml#L6C13-L6C13

This is why Chromatic isn't running for your main branch through CI.

@takashi0602
Copy link
Member Author

@tyokinuhata

branches-ignoremainがあるのが原因っぽいねんけど、ここのmain削除してもCIに影響ないか調査してほしい🙏

@tyokinuhata
Copy link
Member

動作自体には影響ないっすね、 main ブランチでChromatic見ないからいらんやろーということでignoreしていた
まさかこれが悪さしてるとはw

@tyokinuhata
Copy link
Member

てかめちゃくちゃサポート丁寧やな、、、

@takashi0602
Copy link
Member Author

調査アザス!
サポートはまじで丁寧でやり取りしてても苦にならなかったっす😌

@tyokinuhata
Copy link
Member

対応済みのためclose

@takashi0602
Copy link
Member Author

Chromatic上でも確認済み🫶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants