Skip to content

Commit

Permalink
[log][api] Fix GCC 4.9 build failure
Browse files Browse the repository at this point in the history
GCC 4.9 used on some Node.js CI machines complains when the control
reaches the end of a non-void function and no return is encountered.

R=bmeurer@google.com, ofrobots@google.com, yangguo@google.com

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I5af0192cb187eccbf34dbb60ff3ac2e4774af803
Reviewed-on: https://chromium-review.googlesource.com/1105619
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53861}
  • Loading branch information
hashseed authored and Commit Bot committed Jun 20, 2018
1 parent f318f98 commit 70c4340
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/api.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10217,6 +10217,10 @@ const char* CodeEvent::GetCodeEventTypeName(CodeEventType code_event_type) {
CODE_EVENTS_LIST(V)
#undef V
}
// The execution should never pass here
UNREACHABLE();
// NOTE(mmarchini): Workaround to fix a compiler failure on GCC 4.9
return "Unknown";
}

CodeEventHandler::CodeEventHandler(Isolate* isolate) {
Expand Down
4 changes: 4 additions & 0 deletions src/log.cc
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ static v8::CodeEventType GetCodeEventTypeForTag(
TAGS_LIST(V)
#undef V
}
// The execution should never pass here
UNREACHABLE();
// NOTE(mmarchini): Workaround to fix a compiler failure on GCC 4.9
return v8::CodeEventType::kUnknownType;
}
#define CALL_CODE_EVENT_HANDLER(Call) \
if (listener_) { \
Expand Down

0 comments on commit 70c4340

Please sign in to comment.