Skip to content

Commit

Permalink
[postmortem] add postmortem metadata for symbols
Browse files Browse the repository at this point in the history
As discussed in nodejs/llnode#156, we need
postmortem metadata for Symbols to properly print Symbol property names
in postmortem debugging tools. Patch suggested by Ben Noordhuis
(nodejs/llnode#156 (comment)).

R=bmeurer@google.com, yangguo@google.com

Change-Id: Ied6d3c079e8b23a9c796bc632c37785ed7dbc118
Reviewed-on: https://chromium-review.googlesource.com/1205052
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55632}
  • Loading branch information
Matheus Marchini authored and Commit Bot committed Sep 5, 2018
1 parent 84121f5 commit 958b761
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
2 changes: 2 additions & 0 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -859,6 +859,8 @@ action("postmortem-metadata") {
"src/objects/js-regexp-string-iterator.h",
"src/objects/map.h",
"src/objects/map-inl.h",
"src/objects/name.h",
"src/objects/name-inl.h",
"src/objects/scope-info.h",
"src/objects/script.h",
"src/objects/script-inl.h",
Expand Down
7 changes: 1 addition & 6 deletions tools/gen-postmortem-metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -417,15 +417,10 @@ def load_objects_from_file(objfilename, checktypes):
# way around.
#
for type in types:
#
# Symbols and Strings are implemented using the same classes.
#
usetype = re.sub('SYMBOL_', 'STRING_', type);

#
# REGEXP behaves like REG_EXP, as in JS_REGEXP_TYPE => JSRegExp.
#
usetype = re.sub('_REGEXP_', '_REG_EXP_', usetype);
usetype = re.sub('_REGEXP_', '_REG_EXP_', type);

#
# Remove the "_TYPE" suffix and then convert to camel case,
Expand Down

0 comments on commit 958b761

Please sign in to comment.