main layout style names have strange convention

[tmattsso]

main layout style names have strange convention; why not use the toplevel main-layout name in the styles instead?

[pleku]

@tmattsso can you please clarify what is strange ??

[tmattsso]

I mean this:
title.addClassName("main-layout__title")

why not just set main-layout for the main layout itself, instead of those weird concatenations

[pleku]

@jouni can clarify, I was the reviewer and just trusted him

[jouni]

Yeah, they are probably strange to Java developers, and I should’ve discussed this with the team.

Front-end devs should recognize BEM when they see it. But, we should perhaps not use BEM in any of our products, and instead always use a new custom element with shadow dom when we want to ensure that styles are properly scoped and easier to maintain. After all, that’s what BEM tries to provide.

So, I’m okay if we want to update the class names. But, we should not encourage bad practices, and at least encapsulate the header/nav bar into a separate component with its own style scope.