Skip to content
This repository has been archived by the owner on Mar 4, 2022. It is now read-only.

Unstaged files after running #334

Open
Legioth opened this issue Apr 10, 2019 · 1 comment
Open

Unstaged files after running #334

Legioth opened this issue Apr 10, 2019 · 1 comment
Labels

Comments

@Legioth
Copy link
Member

Legioth commented Apr 10, 2019

One the 2.0 branch, run mvn jetty:run and shut it down.

After this, git status reports an untracked src/main/webapp/build/ directory that contains a stats.json file. I would expect no untracked files to appear by running the project.

I would recommend putting that file somewhere inside /target so that it's automatically ignored. As an alternative, the file could also be listed in .gitignore, but I see that as a less user-friendly option since stats.json is really just an implementation detail that a typical user never needs to see. If only adding it to .gitignore, then mvn clean should also be updated to remove the file.

@SomeoneToIgnore
Copy link
Contributor

The issue is caused by the fact that there are two ways the Flow app can create the webpack config: either through the flow-maven-plugin (and this case works fine) or through the flow-server in DevModeInitializer.

As discussed with the team, having the frontend tools' files generation logic in flow-server is a no-go and this logic should be moved into flow-maven-plugin entirely.
This will be done via https://github.com/vaadin/flow/issues/5452 and should fix this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants