Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support serialization of Vaadin scoped beans (#20394) (CP: 24.5) #20427

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

Makes sure that VaadinSession and UI thread locals are available during
both serialization and deserialization, to allow other libraries to
perform inspection and injection of Vaadin scoped beans.

Also refactors VaadinRouteScope to be independent from VaadinService
when fetching RouteScopeOwner annotation for the bean, and replaces
VaadinSession.unlock() calls with direct access to the lock instance
to prevent unwanted push during bean lookup.

Fixes #19967
Part of vaadin/kubernetes-kit#140

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Copy link

sonarcloud bot commented Nov 7, 2024

Copy link

github-actions bot commented Nov 7, 2024

Test Results

1 142 files  ±0  1 142 suites  ±0   1h 26m 28s ⏱️ +4s
7 471 tests +2  7 421 ✅ +2  50 💤 ±0  0 ❌ ±0 
7 833 runs   - 4  7 774 ✅  - 3  59 💤  - 1  0 ❌ ±0 

Results for commit a8fbd58. ± Comparison against base commit febbb85.

@mcollovati mcollovati merged commit 99bef0b into 24.5 Nov 7, 2024
26 checks passed
@mcollovati mcollovati deleted the cherry-pick-20394-to-24.5-1730977711794 branch November 7, 2024 12:19
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.5.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants