-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Save dotfile in dumb background task #169
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a64ada7
Save dotfile as dumb background task
MarcinVaadin 7bae264
remove wrappers as they are included already inside save and remove m…
MarcinVaadin 97ca323
Merge branch 'main' into fix/save-dotfile-after-indexing
MarcinVaadin d6d362a
merge main
MarcinVaadin 5081ec9
spotless
MarcinVaadin cbdffc6
Merge branch 'main' into fix/save-dotfile-after-indexing
MarcinVaadin 5838f6c
Merge branch 'main' into fix/save-dotfile-after-indexing
MarcinVaadin 27c8aca
Wait for smart mode in tests
MarcinVaadin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,5 @@ | ||
package com.vaadin.plugin.copilot.listeners | ||
|
||
import com.intellij.openapi.application.WriteAction | ||
import com.intellij.openapi.application.runInEdt | ||
import com.intellij.openapi.project.Project | ||
import com.intellij.openapi.project.ProjectManager | ||
import com.intellij.openapi.project.ProjectManagerListener | ||
|
@@ -16,12 +14,8 @@ class CopilotVaadinProjectListener : VaadinProjectListener { | |
override fun vaadinProjectDetected(project: Project) { | ||
if (!triggered) { | ||
triggered = true | ||
runInEdt { | ||
WriteAction.run<Throwable> { | ||
saveDotFile(project) | ||
removeDotFileOnExit(project) | ||
} | ||
} | ||
saveDotFile(project) | ||
removeDotFileOnExit(project) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wrappers are not needed as both actions are using those wrappers inside |
||
} | ||
} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sonar: Redundant qualifier