fix: do not delegate focus when clicking on non-focusable child #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
commented
Mar 17, 2022
Comment on lines
+146
to
+162
| /** | ||
| * Override logic from vaadin-control-state-mixin to only focus the summary element | ||
| * when using keyboard navigation. This avoids issues when clicking into the details, | ||
| * such as text selection and click events not working | ||
| * @override | ||
| * @protected | ||
| */ | ||
| _focus() { | ||
| if (!this.focusElement || this._isShiftTabbing) { | ||
| return; | ||
| } | ||
|
|
||
| if (this._keyboardActive) { | ||
| this.focusElement.focus(); | ||
| } | ||
| this._setFocused(true); | ||
| } |
There was a problem hiding this comment.
This just duplicates the logic from ControlStateMixin, while adding the check for this._keyboardActive on line 158.
|
|
sissbruecker
force-pushed
the
fix/delegate_focus_keyboard_only
branch
from
f1ca023
to
86656ce
Compare
web-padawan
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back-port of vaadin/web-components#3565