Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users are expecting more than layout from vaadin-form-layout #28

Closed
limonte opened this issue May 2, 2017 · 5 comments
Closed

Users are expecting more than layout from vaadin-form-layout #28

limonte opened this issue May 2, 2017 · 5 comments
Labels
documentation Improvements or additions to documentation

Comments

@limonte
Copy link
Contributor

limonte commented May 2, 2017

Probably we should consider renaming the element or adding a well visible statement in docs that vaadin-form-layout is only about the layout, there's nothing about validation or object with fields' values, etc.

(This is the DX tests finding)

@limonte limonte added documentation Improvements or additions to documentation question Question about using the component labels May 2, 2017
@jouni
Copy link
Member

jouni commented May 2, 2017

This is the situation for 1.0, and it is reflected in the name, right? Also, there have been vague plans about adding more form features to it in the future, like you mentioned, or generating a form out of a JS object automatically.

@limonte
Copy link
Contributor Author

limonte commented May 2, 2017

This is the situation for 1.0, and it is reflected in the name, right?

Rigth.

Also, there have been vague plans about adding more form features to it in the future, like you mentioned, or generating a form out of a JS object automatically.

In that case, the layout part of the component name will be inaccurate :/

@jouni
Copy link
Member

jouni commented May 2, 2017

In that case, the layout part of the component name will be inaccurate :/

Yeah, probably. But those plans are really vague at the moment, so I wouldn’t worry about it. We can introduce another element for those features if needed, and use this layout inside it.

@limonte
Copy link
Contributor Author

limonte commented May 2, 2017

Add a notification that it's only about the layout, nothing more than that.

@limonte limonte removed the question Question about using the component label May 2, 2017
@web-padawan
Copy link
Member

The description at https://vaadin.com/components/vaadin-form-layout is probably enough.

The Web Component providing configurable responsive layout for form elements. Part of the Vaadin components.

Features
Responsive
Makes sure your form content stays easily readable on all devices.

Also the component is under "Layouts" block at https://vaadin.com/components.

So I'm closing this issue as outdated. The need for a form component can be discussed in other issues, and we have a place for it at https://github.com/vaadin/proposal-for-vaadin-form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants