Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[date-picker] Page background visible behing fullscreen overlay when using Material theme #4814

Closed
sissbruecker opened this issue Oct 24, 2022 · 0 comments · Fixed by #4835
Closed

Comments

@sissbruecker
Copy link
Contributor

Description

When using the Material theme, the page background is visible behind the full-screen overlay:

Bildschirmaufnahme.2022-10-24.um.11.29.10.mov

The browser console shows a warning that might be related:

The custom element definition for "vaadin-overlay"
      was finalized before a style module was registered.
      Make sure to add component specific style modules before
      importing the corresponding custom element.

I was testing this with the date picker dev page, run with web-dev-server.

Expected outcome

The page background should not be visible behind the overlay.

Minimal reproducible example

<script type="module">
  import '@vaadin/date-picker/theme/material/vaadin-date-picker.js';
</script>
<vaadin-date-picker label="Start date"></vaadin-date-picker>

Steps to reproduce

  1. Modify import in dev/date-picker.html to @vaadin/date-picker/theme/material/vaadin-date-picker.js
  2. Run yarn start, open date picker dev page
  3. Adjust browser window to mobile size
  4. Open date picker

Environment

Vaadin version(s): Tested in 24, 23

Browsers

Issue is not browser related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants