Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD Holidays from Bolivia? #679

Closed
djcrawleravp opened this issue Jun 30, 2022 · 13 comments
Closed

ADD Holidays from Bolivia? #679

djcrawleravp opened this issue Jun 30, 2022 · 13 comments

Comments

@djcrawleravp
Copy link

If is not much to ask?

https://publicholidays.com.bo/

Thanks!

@jusce17
Copy link
Contributor

jusce17 commented Jul 6, 2022

Hi @djcrawleravp is there any special rule about the holidays in Bolivia?
like, if it lays on a sunday, do you guys get monday off as well ?

TIA (WIP)

@djcrawleravp
Copy link
Author

All religious holidays are on the exact date, non religious ones are moved to monday if they are on a sunday :3

@dr-prodigy
Copy link
Collaborator

dr-prodigy commented Jul 25, 2022

Hi,
this is a completely voluntary-backed project, so we won't accept any request for specific features.

On the other hand, all contributions are always more than welcome so, if you're interested in python-holidays and / or available to give your support, my suggestion is to implement them yourself, or wait for someone to commit to this task.

Pls start from here for details:
https://github.com/dr-prodigy/python-holidays#contributions

Marking this as "help wanted".. Thx!

@djcrawleravp
Copy link
Author

I'll love to, but I'm not a developer :/, thanks anyway

@kasya
Copy link
Contributor

kasya commented Sep 7, 2022

I'd like to work on this one.

@djcrawleravp one more question. Are regional holidays days off too in those specific regions? For instance, is Chuquisaca Day (May 25) is a day off in the Bolivian department of Chuquisaca?

@djcrawleravp
Copy link
Author

I'd like to work on this one.

@djcrawleravp one more question. Are regional holidays days off too in those specific regions? For instance, is Chuquisaca Day (May 25) is a day off in the Bolivian department of Chuquisaca?

Thank you Kasya, Yes, regional holidays days off are on the specific regions

@kasya
Copy link
Contributor

kasya commented Sep 11, 2022

Hi @djcrawleravp,

Could you please verify test outputs for Bolivian holidays?
Here is a printout for 2021, with observed holidays:

2021-01-01 Año Nuevo
2021-01-22 Nacimiento del Estado Plurinacional de Bolivia
2021-02-15 Feriado por Carnaval
2021-02-16 Feriado por Carnaval (Observed)
2021-04-02 Viernes Santo
2021-05-01 Dia del trabajo
2021-06-03 Corpus Christi
2021-06-21 Año Nuevo Andino
2021-08-02 Día de la Revolución Agraria
2021-08-06 Dia de la Patria
2021-11-02 Todos Santos
2021-12-25 Navidad

Here's one for 2022, with observed holidays:

2022-01-01 Año Nuevo
2022-01-22 Nacimiento del Estado Plurinacional de Bolivia
2022-02-28 Feriado por Carnaval
2022-03-01 Feriado por Carnaval (Observed)
2022-04-15 Viernes Santo
2022-05-01 Dia del trabajo
2022-05-02 Dia del trabajo (Observed)
2022-06-16 Corpus Christi
2022-06-21 Año Nuevo Andino
2022-08-02 Día de la Revolución Agraria
2022-08-06 Dia de la Patria
2022-11-02 Todos Santos
2022-12-25 Navidad
2022-12-26 Navidad (Observed)

Here'e one for 2023, with observed holidays:

2023-01-01 Año Nuevo
2023-01-02 Año Nuevo (Observed)
2023-01-22 Nacimiento del Estado Plurinacional de Bolivia
2023-02-20 Feriado por Carnaval
2023-02-21 Feriado por Carnaval (Observed)
2023-04-07 Viernes Santo
2023-05-01 Dia del trabajo
2023-06-08 Corpus Christi
2023-06-21 Año Nuevo Andino
2023-08-02 Día de la Revolución Agraria
2023-08-06 Dia de la Patria
2023-08-07 Dia de la Patria (Observed)
2023-11-02 Todos Santos
2023-12-25 Navidad

And here's one for 2022, Santa Cruz department with observed holidays:

2022-01-01 Año Nuevo
2022-01-22 Nacimiento del Estado Plurinacional de Bolivia
2022-02-28 Feriado por Carnaval
2022-03-01 Feriado por Carnaval (Observed)
2022-04-15 Viernes Santo
2022-05-01 Dia del trabajo
2022-05-02 Dia del trabajo (Observed)
2022-06-16 Corpus Christi
2022-06-21 Año Nuevo Andino
2022-08-02 Día de la Revolución Agraria
2022-08-06 Dia de la Patria
2022-09-24 Día del departamento de Santa Cruz
2022-11-02 Todos Santos
2022-12-25 Navidad
2022-12-26 Navidad (Observed)

Thanks!

@djcrawleravp
Copy link
Author

Hey @kasya! Thank you so much for this!.

Indeed those Holidays are correct, I don't quite understand what (Observed) mean but certainly those days are incorrect

@kasya
Copy link
Contributor

kasya commented Sep 12, 2022

Hey @djcrawleravp ,

I don't quite understand what (Observed) mean but certainly those days are incorrect

Observed holiday in this case is when a holiday falls on Sunday and you get next Monday as a day off (for non-religious holidays). As I understood after your reply on Jul 6 - that's the way in Bolivia. I also googled a bit and it seems that Bolivia does have observed holidays that fall on Sunday.
Is that not correct?

@djcrawleravp
Copy link
Author

Hi @kasya,

I did my research in here and find out that Sunday holidays are moved to the next day.

In case of "Feriado de Carnaval" is a little bit complex. These are 2 Days (Monday and Tuesday) before "Viernes Santo)

In other words, Your output is correct, I was mistaken :P

@kasya
Copy link
Contributor

kasya commented Sep 12, 2022

@djcrawleravp great, thanks for checking!
It is my understanding that these changes should be added to beta with next update.

@djcrawleravp
Copy link
Author

Thank you very much @kasya !!!

@dr-prodigy
Copy link
Collaborator

@kasya + everyone, that's what I've just done: #698 merged today in beta 👍
Release in master + new PyPi release will follow, as per our standard release workflow.
Thanks a lot everyone, cheers!
dr-p

@dr-prodigy dr-prodigy mentioned this issue Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants