Skip to content

Commit

Permalink
Update PR template and contributing guidelines (#1574)
Browse files Browse the repository at this point in the history
  • Loading branch information
arkid15r authored Nov 26, 2023
1 parent ff1b55c commit ea38c85
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
5 changes: 2 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,8 @@ Your PR description goes here.
-->

- [ ] I've followed the [contributing guidelines][contributing-guidelines]
- [ ] I've added references to all holidays information sources used in this PR
- [ ] The code style looks good: `make pre-commit` command generates no changes
- [ ] All tests pass locally: `make test`, `make tox` (we strongly encourage adding tests to your code)
- [ ] I've run `make pre-commit`, it didn't generate any changes
- [ ] I've run `make test`, all tests passed locally

<!--
Thanks again for your contribution!
Expand Down
9 changes: 5 additions & 4 deletions CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,11 @@ Basics

When contributing with fixes and new features, please start forking/branching
from the `beta branch`_ to work on the latest code and reduce merging issues.

Contributed PRs_ are required to include valid test coverage **(the goal is
100% coverage)** in order to be merged. Please don't hesitate to ask for
help if you'read struggling with tests.
If you add/change holiday official dates or names you must include references to
all sources (government sites, archived web pages, wiki pages, etc) you've used
while working on this PR. Contributed PRs_ are required to include valid test
coverage in order to be merged. Please don't hesitate to ask for help if you
need one with the tests.

Thanks a lot for your support.

Expand Down

0 comments on commit ea38c85

Please sign in to comment.