-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support gossipsub 1.2.0 #1102
Comments
Is it enough to create a new version here
|
Generally, yes. Still, would make sense to just up the version number to fix the issue of not receiving Let's also double check our current implementation matches the spec. |
work on this started in #1106 |
Gossipsub-v1.2 specification suggest that we MAY cancel outstanding IWANT if we receive the message from some other peer This specification also suggests that we SHOULD cancel any queued IWANT reply if we receive IDONTWANT from the requesting peer. IMO, we have this available in this draft PR |
libp2p/specs#548 - this has been merged and IDONTWANT is officially part of the spec - the feature is formally only enabled in gossipsub 1.2.0, meaning we must start supporting that version as a protocol in order to receive IDONTWANT messages from other clients (putting the fields in 1.1 was a hack).
The text was updated successfully, but these errors were encountered: