Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gossipsub 1.2.0 #1102

Closed
arnetheduck opened this issue May 24, 2024 · 4 comments · Fixed by #1106
Closed

Support gossipsub 1.2.0 #1102

arnetheduck opened this issue May 24, 2024 · 4 comments · Fixed by #1106
Assignees

Comments

@arnetheduck
Copy link
Contributor

libp2p/specs#548 - this has been merged and IDONTWANT is officially part of the spec - the feature is formally only enabled in gossipsub 1.2.0, meaning we must start supporting that version as a protocol in order to receive IDONTWANT messages from other clients (putting the fields in 1.1 was a hack).

@diegomrsantos
Copy link
Contributor

Is it enough to create a new version here

GossipSubCodec_10* = "/meshsub/1.0.0"
and add it here
g.codecs &= GossipSubCodec_10
?

@kaiserd
Copy link
Collaborator

kaiserd commented May 24, 2024

Generally, yes.
We should also limit sending IDONTWANT to peers that support v 1.2.0.

Still, would make sense to just up the version number to fix the issue of not receiving IDONTWANT from 1.2 version impls.

Let's also double check our current implementation matches the spec.

@kaiserd
Copy link
Collaborator

kaiserd commented Jun 3, 2024

work on this started in #1106

@ufarooqstatus
Copy link
Collaborator

Gossipsub-v1.2 specification suggest that we MAY cancel outstanding IWANT if we receive the message from some other peer

This specification also suggests that we SHOULD cancel any queued IWANT reply if we receive IDONTWANT from the requesting peer. IMO, we have this available in this draft PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants