Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanups #620

Closed
8 of 9 tasks
Menduist opened this issue Aug 31, 2021 · 2 comments
Closed
8 of 9 tasks

Various cleanups #620

Menduist opened this issue Aug 31, 2021 · 2 comments

Comments

@Menduist
Copy link
Contributor

Menduist commented Aug 31, 2021

Some groundwork for V1:

  • Mount PushIdentify by default in newStandardSwitch
  • Try to remove as much exported procs & fields as possible
  • Remove raise without explicit exception (should be raise exc)
  • Check that we don't try to catch RangeError (or other defects)
  • Remove the need for stdlib random
  • Check the new/init procs
  • Remove deprecated procs
  • Fix compilation warnings
  • Try to lower the recursive dependency count as low as possible
@arnetheduck
Copy link
Contributor

Mount PushIdentify by default in newStandardSwitch

we've avoided any strictly unnecessary protocols so as to reduce the security surface area and information leaks in the "default" setup - by not having them enabled, users of libp2p are made aware of each protocol that they're enabling so they can analyze its usefulness for their application - eth2 for example likely shouldn't have it enabled

@Menduist
Copy link
Contributor Author

Done except the Push Identify

@kaiserd kaiserd moved this to new in nim-libp2p May 2, 2024
@kaiserd kaiserd moved this from new to done in nim-libp2p May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants