-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async exception tracking #962
Comments
Already breaks compatibility if raising a new type ( |
async raises have been merged in chronos, so this is now unblocked |
Have started annotating For callbacks, there's a way to allow |
Once status-im/nim-chronos#251 is merged, and some time has passed, we should start to integrate it in libp2p API
This will require to think long and hard about how we handle exceptions, and will probably catch a lot of exception bugs
While exception tracking can mostly be added in a backward-compatible manner, that is not the case for async callbacks (for instance, gossipsub validators). We can either breack backward compatibility (requires a 2.0), or just keep the callbacks unchecked (seems reasonable)
Also keep in mind that once exception tracking is in, adding new exceptions will break compatbilitly
The text was updated successfully, but these errors were encountered: