Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the Protocol Fees using the RLN contract constructor instead of hard coded #8

Open
kgrgpg opened this issue Sep 18, 2022 · 0 comments

Comments

@kgrgpg
Copy link
Contributor

kgrgpg commented Sep 18, 2022

Protocol fees has been implemented and hardcoded to 20% of the membership deposit as explained in #5 . This method works well as a reference to show the calculations involved using the WAD. There might also be some gas cost savings involved.

But there is a requirement to pass the percentage as a parameter in the constructor for easy deployment of contract. But should this be considered, since passing the fees as parameter would result in lower visibility to the contract readers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant