Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review MP bonus formula #54

Open
0x-r4bbit opened this issue Oct 14, 2024 · 1 comment
Open

Review MP bonus formula #54

0x-r4bbit opened this issue Oct 14, 2024 · 1 comment

Comments

@0x-r4bbit
Copy link
Collaborator

This was raised by @3esmit in #48 (comment).

Also, I didnt understand yet why the $MP_{bonus}$ is being calculated as it is.
Currently RewardsStreamerMP uses:

$$ MP_{bonus} = A_{balance} * \frac{\left(\frac{t_{locked} \times M_{MAX} \times {SCALE_{FACTOR}}} {t_{MAX}} \right)}{SCALE_{FACTOR}} $$

Why not use the normal formula?

$$ MP_{\text{bonus}} = A_{balance} + \left( \frac{A_{balance} \times t_{locked}}{t_{year}} \right) $$

Goal of this issue to analyze the impact of these two versions and making the changes if necessary.
There's also a chance we can stick with what we have, but right now it seems unclear.

@3esmit
Copy link
Contributor

3esmit commented Oct 14, 2024

Just to help clear-up this formula, removing the $SCALE_{FACTOR}$:

$$ MP_{bonus} = A_{balance} + \left(A_{balance} \times \left(\frac{t_{locked} \times M_{MAX}}{t_{MAX}}\right)\right) $$

I found this simplification:

$$ MP_{bonus} = A_{balance} \times \left(1 + \frac{t_{locked} \times M_{MAX}}{t_{MAX}} \right) $$

However, I need to check if this simplification is doable in solidity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants