Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

Remove hacky patches #2

Open
oskarth opened this issue Sep 21, 2020 · 1 comment
Open

Remove hacky patches #2

oskarth opened this issue Sep 21, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@oskarth
Copy link
Contributor

oskarth commented Sep 21, 2020

Problem

Currently there are two patches being applied to get basic interop with nim-libp2p. This is hacky and error prone.

Details

See patch folder.

  1. WakuRelay should inherit from GossipSub, or similar. Not just overwrite codec.
  2. Some error re signed peer record I'm not sure about, very ugly hack.

Likely requires making changes to nim-waku too, at least for 2.

A hint: I noticed that nim-waku doesn't appear to send all protocol info in identfiy string (requires TRACE logging).

Acceptance criteria

No patches needed.

@oskarth oskarth added the bug Something isn't working label Oct 5, 2020
@oskarth
Copy link
Contributor Author

oskarth commented Oct 12, 2020

First step here would be to upstream issues here for nim-libp2p.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant