Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safe to remove cmake from vaex-core/pyproject.toml ? #2026

Closed
Haiz14 opened this issue Apr 21, 2022 · 2 comments
Closed

Safe to remove cmake from vaex-core/pyproject.toml ? #2026

Haiz14 opened this issue Apr 21, 2022 · 2 comments

Comments

@Haiz14
Copy link

Haiz14 commented Apr 21, 2022 •
edited
Loading

I was trying to install vaex on termux, but while installing python module cmake a dependency for vaex-core i was facing lots of difficulties.

So, one guy suggested to remove cmake and ninja from pyproject.toml of vaex-core since it's not used at all.( termux/termux-packages#10065 (comment) )

Would it be safe if i remove cmake from vaex-core pyproject.toml ?
@Haiz14 Haiz14 changed the title Safe to remove cmake from vaex-core pyproject.toml ? Safe to remove cmake from vaex-core/pyproject.toml ? Apr 21, 2022
@Haiz14
Copy link
Author

Haiz14 commented Apr 23, 2022

Solved, i just created a dummy cmake, that doesn't even work but i got passed the requirement of not having cmake.

@Haiz14 Haiz14 closed this as completed Apr 23, 2022
@maartenbreddels
Copy link
Member

I'm ok with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maartenbreddels @Haiz14