Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for jBPMN dialect #308

Open
valb3r opened this issue Jan 4, 2022 · 4 comments
Open

Support for jBPMN dialect #308

valb3r opened this issue Jan 4, 2022 · 4 comments
Labels
enhancement New feature or request medium

Comments

@valb3r
Copy link
Owner

valb3r commented Jan 4, 2022

Is your feature request related to a problem? Please describe.
Add support for jBPMN dialect. See #299 (comment) for example

@Damounet
Copy link

Damounet commented Jan 5, 2022

Nice, I'd be glad to help you or test anything if you need.

@valb3r
Copy link
Owner Author

valb3r commented Jan 5, 2022

@Damounet If you are willing to help, you can have a look at https://github.com/valb3r/flowable-bpmn-intellij-plugin/tree/master/activiti-xml-parser - it is an example of what needs to be implemented to parse jBPMN files.
Basically, it would be great if you provide test XML files like the ones here: https://github.com/valb3r/flowable-bpmn-intellij-plugin/tree/master/activiti-xml-parser/src/test/resources
At least files where:

  1. All elements available in jBPMN modeler are present (example https://github.com/valb3r/flowable-bpmn-intellij-plugin/blob/master/activiti-xml-parser/src/test/resources/popurri.bpmn20.xml)
  2. Per element file with all properties declared (example https://github.com/valb3r/flowable-bpmn-intellij-plugin/blob/master/activiti-xml-parser/src/test/resources/custom-service-tasks/script-task.bpmn20.xml)

With these, it would be clearer what is the amount of work. And they are going to be used to test dialect implementation

@Damounet
Copy link

Damounet commented Jan 7, 2022

Is this the kind of stuff you are looking to ?

popurri.bpmn.md
which is represented like that :
Capture d’écran 2022-01-07 à 16 05 04

This file contains all the components I can create.
Too achieve that I used this VsCode extension https://marketplace.visualstudio.com/items?itemName=redhat.vscode-extension-bpmn-editor but I haven't found on their repository (https://github.com/kiegroup/kogito-tooling) any test file like the one you are looking for.

If this suits your needs, I'll work on the on file per component next week :)

@valb3r
Copy link
Owner Author

valb3r commented Jan 8, 2022

@Damounet, thanks

Is this the kind of stuff you are looking to ?

Yes, the only thing the elements need to be connected with sequence flow, as jBPMN seem to use different anchors (center of the rectangle) compared to the current implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium
Projects
Status: TODO
Development

No branches or pull requests

2 participants