Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boot_networklevel_n typo bug in get_list_of_matrices? #30

Open
valentinitnelav opened this issue Oct 22, 2020 · 1 comment
Open

boot_networklevel_n typo bug in get_list_of_matrices? #30

valentinitnelav opened this issue Oct 22, 2020 · 1 comment
Assignees
Labels
invalid This doesn't seem right

Comments

@valentinitnelav
Copy link
Owner

Why isn't there any difference in the two if cases in boot_networklevel_n:

  if (n == 1) {
    results <- get_list_of_matrices(boot_lst, metric_names, n, iter_spl_size)
    # Convert data back to data frame if applicable
    if (! "data.table" %in% cls_data) data.table::setDF(data)
    return(results)

  } else if (n == 2) {
    results <- get_list_of_matrices(boot_lst, metric_names, n, iter_spl_size)
    if (! "data.table" %in% cls_data) data.table::setDF(data)
    return(results)
  }
@valentinitnelav valentinitnelav self-assigned this Oct 22, 2020
@valentinitnelav valentinitnelav added the bug Something isn't working label Oct 22, 2020
@valentinitnelav
Copy link
Owner Author

Note that n differs (1 or 2) and then get_list_of_matrices should behave differently. I guess I wrote this so that maybe nothing happens if n is not 1 or 2? Not sure why I did it in this way and I need to check again with a test.

@valentinitnelav valentinitnelav added invalid This doesn't seem right and removed bug Something isn't working labels Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant