From c9f430d81bfdbb077edfa5d3cc48f314bf831c45 Mon Sep 17 00:00:00 2001 From: Tyler Gillson Date: Thu, 31 Aug 2023 14:22:30 -0600 Subject: [PATCH] fix: omit conditions for uninstalled plugins --- internal/controller/valid8orconfig_controller.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/internal/controller/valid8orconfig_controller.go b/internal/controller/valid8orconfig_controller.go index 47b41af8..12260466 100644 --- a/internal/controller/valid8orconfig_controller.go +++ b/internal/controller/valid8orconfig_controller.go @@ -166,13 +166,12 @@ func (r *Valid8orConfigReconciler) redeployIfNeeded(ctx context.Context, vc *v1a } // delete any plugins that have been removed - for i, c := range vc.Status.Conditions { + for _, c := range vc.Status.Conditions { _, ok := specPlugins[c.PluginName] if !ok && c.Type == v1alpha1.HelmChartDeployedCondition && c.Status == corev1.ConditionTrue { r.Log.V(0).Info("Deleting plugin Helm chart", "namespace", vc.Namespace, "name", c.PluginName) r.deletePlugin(vc, c.PluginName) delete(vc.Annotations, getPluginHashKey(c.PluginName)) - conditions[i] = getHelmChartCondition(c.PluginName, false) } }