Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump plugin versions in helm chart #255

Merged
merged 6 commits into from
May 17, 2024

Conversation

ahmad-ibra
Copy link
Contributor

@ahmad-ibra ahmad-ibra commented May 17, 2024

Prior to these changes, installing the chart via the following command returns some errors:

helm install validator ./chart/validator -n validator --create-namespace

Errors seen in validator-controller-manager:

Error: failed to fetch https://spectrocloud-labs.github.io/validator-plugin-vsphere/validator-plugin-vsphere-0.0.19.tgz : 404 Not Found

After making the changes we're able to install charts succesfully using the above command and all plugins also download.

Note that for now installing the chart via the helm repo also fails with the same errors, so we'll need to get a new version of the helm chart pushed after this is merged:

helm install validator validator/validator -n validator --create-namespace

@ahmad-ibra ahmad-ibra requested review from TylerGillson and removed request for TylerGillson May 17, 2024 18:01
@ahmad-ibra ahmad-ibra marked this pull request as draft May 17, 2024 18:06
@ahmad-ibra ahmad-ibra force-pushed the chore/update-plugin-versions branch 2 times, most recently from 7c2c588 to 121ac36 Compare May 17, 2024 18:20
@ahmad-ibra
Copy link
Contributor Author

@TylerGillson the tests are failing because of this error:

Error: failed to fetch https://spectrocloud-labs.github.io/validator-plugin-network/validator-plugin-network-0.0.14.tgz : 404 Not Found

Do you know why it would be trying to pull the chart from spectrocloud-labs?

@ahmad-ibra ahmad-ibra marked this pull request as ready for review May 17, 2024 19:07
@ahmad-ibra ahmad-ibra force-pushed the chore/update-plugin-versions branch from 121ac36 to 32d99a0 Compare May 17, 2024 19:40
TylerGillson
TylerGillson previously approved these changes May 17, 2024
@TylerGillson TylerGillson self-requested a review May 17, 2024 20:33
Copy link

codecov bot commented May 17, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@ahmad-ibra ahmad-ibra merged commit 1d053f0 into main May 17, 2024
7 checks passed
@ahmad-ibra ahmad-ibra deleted the chore/update-plugin-versions branch May 17, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants