Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: air-gapped support with Hauler #322

Merged
merged 8 commits into from
Jul 12, 2024
Merged

feat: air-gapped support with Hauler #322

merged 8 commits into from
Jul 12, 2024

Conversation

TylerGillson
Copy link
Member

@TylerGillson TylerGillson commented Jul 12, 2024 •
edited
Loading

Description

Related:

@TylerGillson
feat: oci client [WIP]
6496163 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
chore: reinstate CAFile
1034487 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Jul 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 117 lines in your changes missing coverage. Please review.

@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
- Coverage   49.66%   45.48%   -4.19%     
==========================================
  Files          20       22       +2     
  Lines        1206     1317     +111     
==========================================
  Hits          599      599              
- Misses        540      651     +111     
  Partials       67       67
Files Coverage Δ
api/v1alpha1/validatorconfig_types.go 100.00% <ø> (ø)
internal/controller/validatorconfig_controller.go 69.81% <0.00%> (-2.28%) ⬇️
pkg/util/file.go 0.00% <0.00%> (ø)
pkg/oci/oci_client.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ed954...09e91bf. Read the comment docs.

@TylerGillson
docs: justify OCI client
96e862d 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
feat: hauler support for air-gap [WIP]
5b62281 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
feat: hauler support for air-gap [WIP]
146af8d 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
feat: hauler support for air-gap [WIP]
85fb9fe 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
feat: hauler support for air-gap [WIP]
827d477 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson changed the title feat: pull charts with oci client feat: air-gapped support with Hauler Jul 12, 2024
@TylerGillson TylerGillson marked this pull request as ready for review July 12, 2024 15:49
@TylerGillson TylerGillson requested a review from a team as a code owner July 12, 2024 15:49
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement Enhancement to an existing feature labels Jul 12, 2024
@TylerGillson TylerGillson mentioned this pull request Jul 12, 2024
Merged
ahmad-ibra
ahmad-ibra previously approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@ahmad-ibra ahmad-ibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like theres a couple gosec issues that you might need to ignore to get CI passing though

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 12, 2024
@TylerGillson
chore: fix gosec issues
09e91bf 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson merged commit 4cd726d into main Jul 12, 2024
6 of 7 checks passed
@TylerGillson TylerGillson deleted the feat/hauler branch July 12, 2024 21:28
@TylerGillson TylerGillson mentioned this pull request Jul 12, 2024
Merged
TylerGillson added a commit that referenced this pull request Jul 12, 2024
@TylerGillson
chore(main): release 0.0.46 (#324)
b5edbcd 
🤖 I have created a release *beep* *boop*
---


##
[0.0.46](v0.0.45...v0.0.46)
(2024-07-12)


### Features

* air-gapped support with Hauler
([#322](#322))
([4cd726d](4cd726d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
TylerGillson added a commit to validator-labs/validatorctl that referenced this pull request Jul 15, 2024
@TylerGillson @ahmad-ibra
feat: air-gapped support with hauler (#74)
aa3fd73 
## Description
- use OCI client instead of Helm client due to
helm/helm#12810
- prompt user for Hauler configuration for air-gapped installs &
customize image and chart endpoints accordingly
- reinstate advanced kind config that was inexplicably removed
- fix containerdConfigPatches for insecure registries in kind cluster
template
- bump kindest/node image
- bump kube-rbac-proxy images

Requires:
- validator-labs/validator#322

---------

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Co-authored-by: Ahmad Malik Ibrahim <ahmad.ibrahim@spectrocloud.com>
@TylerGillson TylerGillson mentioned this pull request Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmad-ibra ahmad-ibra ahmad-ibra left review comments

Assignees
No one assigned
Labels
enhancement Enhancement to an existing feature lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerGillson @ahmad-ibra