Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure validatorctl arch matches haul arch #374

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Conversation

TylerGillson
Copy link
Member

Issue

Resolves #372

Description

Dynamically update validatorctl binary arch during make haul.

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson requested a review from a team as a code owner August 8, 2024 14:04
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 8, 2024
@dosubot dosubot bot added the bug Something isn't working label Aug 8, 2024
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
- Coverage   54.21%   53.85%   -0.36%     
==========================================
  Files          21       21              
  Lines        1127     1127              
==========================================
- Hits          611      607       -4     
- Misses        448      451       +3     
- Partials       68       69       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37fa8f3...f58094a. Read the comment docs.

@TylerGillson TylerGillson merged commit ca38f3e into main Aug 8, 2024
8 checks passed
@TylerGillson TylerGillson deleted the ci/haul-archs branch August 8, 2024 15:46
TylerGillson added a commit that referenced this pull request Aug 8, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.1.2](v0.1.1...v0.1.2)
(2024-08-08)


### Bug Fixes

* ensure validatorctl arch matches haul arch
([#374](#374))
([ca38f3e](ca38f3e))


### Other

* **deps:** bump github.com/docker/docker from 24.0.9+incompatible to
25.0.6+incompatible
([#368](#368))
([7e21122](7e21122))


### Dependency Updates

* **deps:** update module github.com/onsi/ginkgo/v2 to v2.20.0
([#373](#373))
([37fa8f3](37fa8f3))
* **deps:** update module github.com/validator-labs/validator-plugin-oci
to v0.0.13
([#369](#369))
([a06d799](a06d799))
* **deps:** update module github.com/validator-labs/validator-plugin-oci
to v0.1.0
([#375](#375))
([ddfd175](ddfd175))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Hauls for the arm64 architecture include amd64 validatorctl binary
1 participant