fix: ensure all oci auth secrets in values.yaml are created #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
TylerGillson
approved these changes
Aug 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #390 +/- ##
=======================================
Coverage 54.02% 54.02%
=======================================
Files 21 21
Lines 1131 1131
=======================================
Hits 611 611
Misses 452 452
Partials 68 68 Continue to review full report in Codecov by Sentry.
|
ahmad-ibra
changed the title
ahmad-ibra
pushed a commit
that referenced
this pull request
Aug 14, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.5](v0.1.4...v0.1.5) (2024-08-14) ### Bug Fixes * ensure all oci auth secrets in values.yaml are created ([#390](#390)) ([8c0e4fb](8c0e4fb)) ### Dependency Updates * **deps:** update module sigs.k8s.io/cluster-api to v1.8.1 ([#383](#383)) ([f909931](f909931)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously when adding multiple oci secrets, only the last secret added to the values.yaml was being created. This change ensures that our oci-auth template does not overwrite previous secrets.