feat: introduce PluginSpec interface #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
dosubot
bot
added
size:M
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #403 +/- ##
==========================================
- Coverage 54.02% 53.78% -0.24%
==========================================
Files 21 22 +1
Lines 1131 1136 +5
==========================================
Hits 611 611
- Misses 452 457 +5
Partials 68 68 Continue to review full report in Codecov by Sentry.
|
TylerGillson
approved these changes
Aug 23, 2024
ahmad-ibra
pushed a commit
that referenced
this pull request
Aug 23, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.8](v0.1.7...v0.1.8) (2024-08-23) ### Features * introduce PluginSpec interface ([#403](#403)) ([3adc6a0](3adc6a0)) ### Dependency Updates * **deps:** update module github.com/onsi/ginkgo/v2 to v2.20.1 ([#398](#398)) ([baa9201](baa9201)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Related to validator-labs/validatorctl#178
Description
This introduces a PluginSpec interface that all plugins must implement. Validatorctl will be able to use this spec to collect all crd's that it would directly invoke.