-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: cluster-require-full-coverage no - scan fail #2436
Comments
@raphaelauv Hi, Less relevant, but the improvement of scan with match can be done (internally by Valkey) per node, but not per cluster. |
hi, thanks @avifenesh we want our scan to work even with missing nodes (we have big cluster(s) and a missing node is a common thing) would be great that we can explicitly use scan with a |
The challenge with missing nodes and cluster scan is that in such cases we can't provide any guarantee about the validity of the scan. Since currently there's no cluster wide scan provided by Valkey, we need to create some complex logic to provide this kind of scan with the guarantees of scan. The solution in such a case would probably be to iterate blindly over the cluster nodes and to ignore nodes that have connection issues, without giving guarantees, and users will need to choose this scan type ahead with an optional flag or so. In your case, you would prefer to use a scan with no guarantees over a scan with guarantees which can't scan a not covered cluster? I'm just trying to get the picture and to understand the needs better. If you are fine with sharing this information, i would also like to hear why a case of missing nodes (a full shard, in case you have replicas) is common. |
yes this is the missing feature |
Avi is there any workaround we can provide? |
@asafpor I will check. Can also try to speed up a patch. @raphaelauv is it blocking you currently from working with Glide? |
Describe the bug
When I scan a redis cluster with a missing node , the scan do not work even if the redis cluster is setup with
cluster-require-full-coverage no
Expected Behavior
with
cluster-require-full-coverage no
a redis scan should work with a missing node , like this ->Current Behavior
scan fail with a log on the missing node
Reproduction Steps
Possible Solution
No response
Additional Information/Context
No response
Client version used
1.1.0
Engine type and version
8.0.1
OS
ubuntu 22.04
Language
Python
Language Version
3.11
Cluster information
No response
Logs
No response
Other information
No response
The text was updated successfully, but these errors were encountered: