Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Add logo #28

Closed
stockholmux opened this issue Apr 10, 2024 · 1 comment · Fixed by #63
Closed

[Bug] Add logo #28

stockholmux opened this issue Apr 10, 2024 · 1 comment · Fixed by #63
Labels
bug Something isn't working

Comments

@stockholmux
Copy link
Member

stockholmux commented Apr 10, 2024 •
edited
Loading

Describe the bug

Valkey has now has a logo!

valkey-logo-only

Expected behavior

The site should have a logo in the upper left hand corner in the header and should have favico set to the new logo. Ideally this would match the blue text color.

We should also credit the logo creator in the footer.

Screenshots

n/a

Additional context

n/a
@stockholmux stockholmux added the bug Something isn't working label Apr 10, 2024
@stockholmux stockholmux mentioned this issue Apr 11, 2024
Open
24 tasks
@kris-ms kris-ms mentioned this issue May 5, 2024
Merged
@kris-ms
Copy link
Contributor

kris-ms commented May 5, 2024

Hi there, #63 will hopefully close this,

Sing out if there's any problems with the PR and I'll sort it out.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaced logo with wordmark SVG, added artist credit kris-ms/valkey-io.github.io
2 participants
@stockholmux @kris-ms