From 7a3353de5c0b186e92dd48df8de643d395f1eaee Mon Sep 17 00:00:00 2001
From: "wei.kukey" <wei.kukey@gmail.com>
Date: Mon, 10 Jun 2024 11:50:56 +0800
Subject: [PATCH 01/13] script add dump subcommand

Change-Id: I60aacd3198652174883f335b36efc18d69a1fb43
Signed-off-by: wei.kukey <wei.kukey@gmail.com>
---
 src/commands.def              | 26 +++++++++++++++++++++
 src/commands/script-dump.json | 44 +++++++++++++++++++++++++++++++++++
 src/eval.c                    | 22 ++++++++++++++++++
 tests/unit/scripting.tcl      |  5 ++++
 4 files changed, 97 insertions(+)
 create mode 100644 src/commands/script-dump.json

diff --git a/src/commands.def b/src/commands.def
index c59cb01dc1..8cfd40fce7 100644
--- a/src/commands.def
+++ b/src/commands.def
@@ -5210,6 +5210,31 @@ struct COMMAND_ARG SCRIPT_DEBUG_Args[] = {
 {MAKE_ARG("mode",ARG_TYPE_ONEOF,-1,NULL,NULL,NULL,CMD_ARG_NONE,3,NULL),.subargs=SCRIPT_DEBUG_mode_Subargs},
 };
 
+/********** SCRIPT DUMP ********************/
+
+#ifndef SKIP_CMD_HISTORY_TABLE
+/* SCRIPT DUMP history */
+#define SCRIPT_DUMP_History NULL
+#endif
+
+#ifndef SKIP_CMD_TIPS_TABLE
+/* SCRIPT DUMP tips */
+const char *SCRIPT_DUMP_Tips[] = {
+"request_policy:all_shards",
+"response_policy:agg_logical_and",
+};
+#endif
+
+#ifndef SKIP_CMD_KEY_SPECS_TABLE
+/* SCRIPT DUMP key specs */
+#define SCRIPT_DUMP_Keyspecs NULL
+#endif
+
+/* SCRIPT DUMP argument table */
+struct COMMAND_ARG SCRIPT_DUMP_Args[] = {
+{MAKE_ARG("sha1",ARG_TYPE_STRING,-1,NULL,NULL,NULL,CMD_ARG_MULTIPLE,0,NULL)},
+};
+
 /********** SCRIPT EXISTS ********************/
 
 #ifndef SKIP_CMD_HISTORY_TABLE
@@ -5333,6 +5358,7 @@ struct COMMAND_ARG SCRIPT_LOAD_Args[] = {
 /* SCRIPT command table */
 struct COMMAND_STRUCT SCRIPT_Subcommands[] = {
 {MAKE_CMD("debug","Sets the debug mode of server-side Lua scripts.","O(1)","3.2.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_DEBUG_History,0,SCRIPT_DEBUG_Tips,0,scriptCommand,3,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_DEBUG_Keyspecs,0,NULL,1),.args=SCRIPT_DEBUG_Args},
+{MAKE_CMD("dump","Dump server-side Lua scripts in the script cache.","O(N) with N being the number of scripts to check (so checking a single script is an O(1) operation).","7.2.4",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_DUMP_History,0,SCRIPT_DUMP_Tips,2,scriptCommand,-3,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_DUMP_Keyspecs,0,NULL,1),.args=SCRIPT_DUMP_Args},
 {MAKE_CMD("exists","Determines whether server-side Lua scripts exist in the script cache.","O(N) with N being the number of scripts to check (so checking a single script is an O(1) operation).","2.6.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_EXISTS_History,0,SCRIPT_EXISTS_Tips,2,scriptCommand,-3,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_EXISTS_Keyspecs,0,NULL,1),.args=SCRIPT_EXISTS_Args},
 {MAKE_CMD("flush","Removes all server-side Lua scripts from the script cache.","O(N) with N being the number of scripts in cache","2.6.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_FLUSH_History,1,SCRIPT_FLUSH_Tips,2,scriptCommand,-2,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_FLUSH_Keyspecs,0,NULL,1),.args=SCRIPT_FLUSH_Args},
 {MAKE_CMD("help","Returns helpful text about the different subcommands.","O(1)","5.0.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_HELP_History,0,SCRIPT_HELP_Tips,0,scriptCommand,2,CMD_LOADING|CMD_STALE,ACL_CATEGORY_SCRIPTING,SCRIPT_HELP_Keyspecs,0,NULL,0)},
diff --git a/src/commands/script-dump.json b/src/commands/script-dump.json
new file mode 100644
index 0000000000..e97318dc42
--- /dev/null
+++ b/src/commands/script-dump.json
@@ -0,0 +1,44 @@
+{
+    "DUMP": {
+        "summary": "Dump server-side Lua scripts in the script cache.",
+        "complexity": "O(N) with N being the number of scripts to check (so checking a single script is an O(1) operation).",
+        "group": "scripting",
+        "since": "7.2.4",
+        "arity": -3,
+        "container": "SCRIPT",
+        "function": "scriptCommand",
+        "command_flags": [
+            "NOSCRIPT"
+        ],
+        "acl_categories": [
+            "SCRIPTING"
+        ],
+        "command_tips": [
+            "REQUEST_POLICY:ALL_SHARDS",
+            "RESPONSE_POLICY:AGG_LOGICAL_AND"
+        ],
+        "arguments": [
+            {
+                "name": "sha1",
+                "type": "string",
+                "multiple": true
+            }
+        ],
+        "reply_schema": {
+            "description": "An array of lua scripts that correspond to the specified SHA1 digest arguments.",
+            "type": "array",
+            "items": {
+                "oneOf": [
+                    {
+                        "description": "lua script if sha1 hash exists in script cache.",
+                        "type": "string"
+                    },
+                    {
+                        "description": "null if sha1 hash does not exist in script cache.",
+                        "type": "null"
+                    }
+                ]
+            }
+        }
+    }
+}
diff --git a/src/eval.c b/src/eval.c
index 464c8ef487..ca54d66fca 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -35,6 +35,7 @@
  * 2. scriptingInit() - initServer() function from server.c invokes this to initialize LUA at startup.
  *                      It is also invoked between 2 eval invocations to reset Lua.
  */
+#include "dict.h"
 #include "server.h"
 #include "sha1.h"
 #include "rand.h"
@@ -675,6 +676,8 @@ void scriptCommand(client *c) {
 "    Kill the currently executing Lua script.",
 "LOAD <script>",
 "    Load a script into the scripts cache without executing it.",
+"DUMP <sha1> [<sha1> ...]",
+"    Dump a script from the scipts cache.",
 NULL
         };
         /* clang-format on */
@@ -728,6 +731,25 @@ NULL
             addReplyError(c, "Use SCRIPT DEBUG YES/SYNC/NO");
             return;
         }
+    } else if (c->argc > 2 && !strcasecmp(c->argv[1]->ptr, "dump")) {
+        int j;
+        dictEntry *de;
+        luaScript *ls;
+
+        addReplyArrayLen(c, c->argc - 2);
+        for (j = 2; j < c->argc; j++) {
+            if (sdslen(c->argv[j]->ptr) != 40) {
+                addReply(c, shared.null[c->resp]);
+                continue;
+            }
+
+            if ((de = dictFind(lctx.lua_scripts, c->argv[j]->ptr))) {
+                ls = dictGetVal(de);
+                addReplyBulk(c, ls->body);
+            } else {
+                addReply(c, shared.null[c->resp]);
+            }
+        }
     } else {
         addReplySubcommandSyntaxError(c);
     }
diff --git a/tests/unit/scripting.tcl b/tests/unit/scripting.tcl
index 0b7206e2a0..507b0c1fa9 100644
--- a/tests/unit/scripting.tcl
+++ b/tests/unit/scripting.tcl
@@ -638,6 +638,11 @@ start_server {tags {"scripting"}} {
             [r evalsha b534286061d4b9e4026607613b95c06c06015ae8 0]
     } {b534286061d4b9e4026607613b95c06c06015ae8 loaded}
 
+    test {SCRIPT DUMP - is able to dump scripts from the scripting cache} {
+        list \
+            [r script dump b534286061d4b9e4026607613b95c06c06015ae8 b534286061d4b9 b534286061d4b9e4026607613b95c06c06015ae8 b534286061d4b9e4026607613b95c06c06015a11] \
+    } {{{return 'loaded'} {} {return 'loaded'} {}}}
+
     test "SORT is normally not alpha re-ordered for the scripting engine" {
         r del myset
         r sadd myset 1 2 3 4 10

From 893d9da18c70bde1907af79eb4343fb2f737ca99 Mon Sep 17 00:00:00 2001
From: kukey <wei.kukey@gmail.com>
Date: Tue, 11 Jun 2024 05:34:39 +0800
Subject: [PATCH 02/13] Update src/commands/script-dump.json

Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
Signed-off-by: wei.kukey <wei.kukey@gmail.com>
---
 src/commands/script-dump.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/commands/script-dump.json b/src/commands/script-dump.json
index e97318dc42..192b817bc6 100644
--- a/src/commands/script-dump.json
+++ b/src/commands/script-dump.json
@@ -3,7 +3,7 @@
         "summary": "Dump server-side Lua scripts in the script cache.",
         "complexity": "O(N) with N being the number of scripts to check (so checking a single script is an O(1) operation).",
         "group": "scripting",
-        "since": "7.2.4",
+        "since": "8.0.0",
         "arity": -3,
         "container": "SCRIPT",
         "function": "scriptCommand",

From d397507a9af2781296d8bddc1ce9a5ce9c6257dd Mon Sep 17 00:00:00 2001
From: "wei.kukey" <wei.kukey@gmail.com>
Date: Tue, 11 Jun 2024 08:13:51 +0800
Subject: [PATCH 03/13] fix some problem

Change-Id: I5656dc8a4f8010966b3f508e9c72bc7c26395f21
Signed-off-by: wei.kukey <wei.kukey@gmail.com>
---
 src/commands.def              |  9 +++------
 src/commands/script-dump.json | 35 +++++++++++++----------------------
 src/eval.c                    | 26 +++++++++++---------------
 tests/unit/scripting.tcl      |  9 +++++++--
 4 files changed, 34 insertions(+), 45 deletions(-)

diff --git a/src/commands.def b/src/commands.def
index 8cfd40fce7..881b800815 100644
--- a/src/commands.def
+++ b/src/commands.def
@@ -5219,10 +5219,7 @@ struct COMMAND_ARG SCRIPT_DEBUG_Args[] = {
 
 #ifndef SKIP_CMD_TIPS_TABLE
 /* SCRIPT DUMP tips */
-const char *SCRIPT_DUMP_Tips[] = {
-"request_policy:all_shards",
-"response_policy:agg_logical_and",
-};
+#define SCRIPT_DUMP_Tips NULL
 #endif
 
 #ifndef SKIP_CMD_KEY_SPECS_TABLE
@@ -5232,7 +5229,7 @@ const char *SCRIPT_DUMP_Tips[] = {
 
 /* SCRIPT DUMP argument table */
 struct COMMAND_ARG SCRIPT_DUMP_Args[] = {
-{MAKE_ARG("sha1",ARG_TYPE_STRING,-1,NULL,NULL,NULL,CMD_ARG_MULTIPLE,0,NULL)},
+{MAKE_ARG("sha1",ARG_TYPE_STRING,-1,NULL,NULL,NULL,CMD_ARG_NONE,0,NULL)},
 };
 
 /********** SCRIPT EXISTS ********************/
@@ -5358,7 +5355,7 @@ struct COMMAND_ARG SCRIPT_LOAD_Args[] = {
 /* SCRIPT command table */
 struct COMMAND_STRUCT SCRIPT_Subcommands[] = {
 {MAKE_CMD("debug","Sets the debug mode of server-side Lua scripts.","O(1)","3.2.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_DEBUG_History,0,SCRIPT_DEBUG_Tips,0,scriptCommand,3,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_DEBUG_Keyspecs,0,NULL,1),.args=SCRIPT_DEBUG_Args},
-{MAKE_CMD("dump","Dump server-side Lua scripts in the script cache.","O(N) with N being the number of scripts to check (so checking a single script is an O(1) operation).","7.2.4",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_DUMP_History,0,SCRIPT_DUMP_Tips,2,scriptCommand,-3,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_DUMP_Keyspecs,0,NULL,1),.args=SCRIPT_DUMP_Args},
+{MAKE_CMD("dump","Dump server-side Lua script in the script cache.","O(1).","8.0.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_DUMP_History,0,SCRIPT_DUMP_Tips,0,scriptCommand,-3,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_DUMP_Keyspecs,0,NULL,1),.args=SCRIPT_DUMP_Args},
 {MAKE_CMD("exists","Determines whether server-side Lua scripts exist in the script cache.","O(N) with N being the number of scripts to check (so checking a single script is an O(1) operation).","2.6.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_EXISTS_History,0,SCRIPT_EXISTS_Tips,2,scriptCommand,-3,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_EXISTS_Keyspecs,0,NULL,1),.args=SCRIPT_EXISTS_Args},
 {MAKE_CMD("flush","Removes all server-side Lua scripts from the script cache.","O(N) with N being the number of scripts in cache","2.6.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_FLUSH_History,1,SCRIPT_FLUSH_Tips,2,scriptCommand,-2,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_FLUSH_Keyspecs,0,NULL,1),.args=SCRIPT_FLUSH_Args},
 {MAKE_CMD("help","Returns helpful text about the different subcommands.","O(1)","5.0.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_HELP_History,0,SCRIPT_HELP_Tips,0,scriptCommand,2,CMD_LOADING|CMD_STALE,ACL_CATEGORY_SCRIPTING,SCRIPT_HELP_Keyspecs,0,NULL,0)},
diff --git a/src/commands/script-dump.json b/src/commands/script-dump.json
index 192b817bc6..01c5683d7d 100644
--- a/src/commands/script-dump.json
+++ b/src/commands/script-dump.json
@@ -1,7 +1,7 @@
 {
     "DUMP": {
-        "summary": "Dump server-side Lua scripts in the script cache.",
-        "complexity": "O(N) with N being the number of scripts to check (so checking a single script is an O(1) operation).",
+        "summary": "Dump server-side Lua script in the script cache.",
+        "complexity": "O(1).",
         "group": "scripting",
         "since": "8.0.0",
         "arity": -3,
@@ -13,32 +13,23 @@
         "acl_categories": [
             "SCRIPTING"
         ],
-        "command_tips": [
-            "REQUEST_POLICY:ALL_SHARDS",
-            "RESPONSE_POLICY:AGG_LOGICAL_AND"
-        ],
         "arguments": [
             {
                 "name": "sha1",
-                "type": "string",
-                "multiple": true
+                "type": "string"
             }
         ],
         "reply_schema": {
-            "description": "An array of lua scripts that correspond to the specified SHA1 digest arguments.",
-            "type": "array",
-            "items": {
-                "oneOf": [
-                    {
-                        "description": "lua script if sha1 hash exists in script cache.",
-                        "type": "string"
-                    },
-                    {
-                        "description": "null if sha1 hash does not exist in script cache.",
-                        "type": "null"
-                    }
-                ]
-            }
+            "oneOf": [
+                {
+                    "description": "lua script if sha1 hash exists in script cache.",
+                    "type": "string"
+                },
+                {
+                    "description": "null if sha1 hash does not exist in script cache.",
+                    "type": "null"
+                }
+            ]
         }
     }
 }
diff --git a/src/eval.c b/src/eval.c
index ca54d66fca..98449fff36 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -676,7 +676,7 @@ void scriptCommand(client *c) {
 "    Kill the currently executing Lua script.",
 "LOAD <script>",
 "    Load a script into the scripts cache without executing it.",
-"DUMP <sha1> [<sha1> ...]",
+"DUMP <sha1>",
 "    Dump a script from the scipts cache.",
 NULL
         };
@@ -731,24 +731,20 @@ NULL
             addReplyError(c, "Use SCRIPT DEBUG YES/SYNC/NO");
             return;
         }
-    } else if (c->argc > 2 && !strcasecmp(c->argv[1]->ptr, "dump")) {
-        int j;
+    } else if (c->argc == 3 && !strcasecmp(c->argv[1]->ptr, "dump")) {
         dictEntry *de;
         luaScript *ls;
 
-        addReplyArrayLen(c, c->argc - 2);
-        for (j = 2; j < c->argc; j++) {
-            if (sdslen(c->argv[j]->ptr) != 40) {
-                addReply(c, shared.null[c->resp]);
-                continue;
-            }
+        if (sdslen(c->argv[2]->ptr) != 40) {
+            addReplyError(c, "Sha1 length must be 40");
+            return;
+        }
 
-            if ((de = dictFind(lctx.lua_scripts, c->argv[j]->ptr))) {
-                ls = dictGetVal(de);
-                addReplyBulk(c, ls->body);
-            } else {
-                addReply(c, shared.null[c->resp]);
-            }
+        if ((de = dictFind(lctx.lua_scripts, c->argv[2]->ptr))) {
+            ls = dictGetVal(de);
+            addReplyBulk(c, ls->body);
+        } else {
+            addReply(c, shared.null[c->resp]);
         }
     } else {
         addReplySubcommandSyntaxError(c);
diff --git a/tests/unit/scripting.tcl b/tests/unit/scripting.tcl
index 507b0c1fa9..a09a2a1639 100644
--- a/tests/unit/scripting.tcl
+++ b/tests/unit/scripting.tcl
@@ -640,8 +640,13 @@ start_server {tags {"scripting"}} {
 
     test {SCRIPT DUMP - is able to dump scripts from the scripting cache} {
         list \
-            [r script dump b534286061d4b9e4026607613b95c06c06015ae8 b534286061d4b9 b534286061d4b9e4026607613b95c06c06015ae8 b534286061d4b9e4026607613b95c06c06015a11] \
-    } {{{return 'loaded'} {} {return 'loaded'} {}}}
+            [r script dump b534286061d4b9e4026607613b95c06c06015ae8] \
+            [r script dump b534286061d4b9e4026607613b95c06c06015ae1]
+    } {{return 'loaded'} {}}
+
+    test {SCRIPT DUMP - wrong sha1 length} {
+        assert_error "ERR Sha1 length must be 40" {r script dump b534286061d4b06c06015ae8}
+    }
 
     test "SORT is normally not alpha re-ordered for the scripting engine" {
         r del myset

From 259601eb90d5c66b0ad446e5079e16b633a3e3a5 Mon Sep 17 00:00:00 2001
From: kukey <wei.kukey@gmail.com>
Date: Tue, 11 Jun 2024 13:00:17 +0800
Subject: [PATCH 04/13] Update src/commands/script-dump.json

fix arity argument

Co-authored-by: Binbin <binloveplay1314@qq.com>
Signed-off-by: wei.kukey <wei.kukey@gmail.com>
---
 src/commands/script-dump.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/commands/script-dump.json b/src/commands/script-dump.json
index 01c5683d7d..a43cb0086d 100644
--- a/src/commands/script-dump.json
+++ b/src/commands/script-dump.json
@@ -4,7 +4,7 @@
         "complexity": "O(1).",
         "group": "scripting",
         "since": "8.0.0",
-        "arity": -3,
+        "arity": 3,
         "container": "SCRIPT",
         "function": "scriptCommand",
         "command_flags": [

From b5a72a7129517875c96b7fc9d6e20e3ed8602ad1 Mon Sep 17 00:00:00 2001
From: kukey <wei.kukey@gmail.com>
Date: Tue, 11 Jun 2024 13:00:34 +0800
Subject: [PATCH 05/13] Update src/eval.c

Co-authored-by: Binbin <binloveplay1314@qq.com>
Signed-off-by: wei.kukey <wei.kukey@gmail.com>
---
 src/eval.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/eval.c b/src/eval.c
index 98449fff36..9d8348e673 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -677,7 +677,7 @@ void scriptCommand(client *c) {
 "LOAD <script>",
 "    Load a script into the scripts cache without executing it.",
 "DUMP <sha1>",
-"    Dump a script from the scipts cache.",
+"    Dump a script from the scripts cache.",
 NULL
         };
         /* clang-format on */

From 522f0d77128eabd2857a90c8920826f62a7de504 Mon Sep 17 00:00:00 2001
From: "wei.kukey" <wei.kukey@gmail.com>
Date: Tue, 11 Jun 2024 17:33:09 +0800
Subject: [PATCH 06/13] fix linux compile redefine macro

Change-Id: I50d5703c636de565857ea5746d68f4084189a9cf
Signed-off-by: wei.kukey <wei.kukey@gmail.com>
---
 src/eval.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/eval.c b/src/eval.c
index 9d8348e673..a0f515e5e9 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -35,7 +35,6 @@
  * 2. scriptingInit() - initServer() function from server.c invokes this to initialize LUA at startup.
  *                      It is also invoked between 2 eval invocations to reset Lua.
  */
-#include "dict.h"
 #include "server.h"
 #include "sha1.h"
 #include "rand.h"

From fc146f79977e487072e68035a6def1b297037a0c Mon Sep 17 00:00:00 2001
From: "wei.kukey" <wei.kukey@gmail.com>
Date: Wed, 12 Jun 2024 15:08:05 +0800
Subject: [PATCH 07/13] invalid sha1 return noscript error message

Change-Id: Icd4ccc06a2a970d04ac12d5f9cbc01613b493bce
Signed-off-by: wei.kukey <wei.kukey@gmail.com>
---
 src/commands.def         |  2 +-
 src/eval.c               |  7 +------
 src/server.c             |  2 +-
 tests/unit/scripting.tcl | 17 +++++++++++------
 4 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/commands.def b/src/commands.def
index 881b800815..11a100ffbf 100644
--- a/src/commands.def
+++ b/src/commands.def
@@ -5355,7 +5355,7 @@ struct COMMAND_ARG SCRIPT_LOAD_Args[] = {
 /* SCRIPT command table */
 struct COMMAND_STRUCT SCRIPT_Subcommands[] = {
 {MAKE_CMD("debug","Sets the debug mode of server-side Lua scripts.","O(1)","3.2.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_DEBUG_History,0,SCRIPT_DEBUG_Tips,0,scriptCommand,3,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_DEBUG_Keyspecs,0,NULL,1),.args=SCRIPT_DEBUG_Args},
-{MAKE_CMD("dump","Dump server-side Lua script in the script cache.","O(1).","8.0.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_DUMP_History,0,SCRIPT_DUMP_Tips,0,scriptCommand,-3,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_DUMP_Keyspecs,0,NULL,1),.args=SCRIPT_DUMP_Args},
+{MAKE_CMD("dump","Dump server-side Lua script in the script cache.","O(1).","8.0.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_DUMP_History,0,SCRIPT_DUMP_Tips,0,scriptCommand,3,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_DUMP_Keyspecs,0,NULL,1),.args=SCRIPT_DUMP_Args},
 {MAKE_CMD("exists","Determines whether server-side Lua scripts exist in the script cache.","O(N) with N being the number of scripts to check (so checking a single script is an O(1) operation).","2.6.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_EXISTS_History,0,SCRIPT_EXISTS_Tips,2,scriptCommand,-3,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_EXISTS_Keyspecs,0,NULL,1),.args=SCRIPT_EXISTS_Args},
 {MAKE_CMD("flush","Removes all server-side Lua scripts from the script cache.","O(N) with N being the number of scripts in cache","2.6.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_FLUSH_History,1,SCRIPT_FLUSH_Tips,2,scriptCommand,-2,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_FLUSH_Keyspecs,0,NULL,1),.args=SCRIPT_FLUSH_Args},
 {MAKE_CMD("help","Returns helpful text about the different subcommands.","O(1)","5.0.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_HELP_History,0,SCRIPT_HELP_Tips,0,scriptCommand,2,CMD_LOADING|CMD_STALE,ACL_CATEGORY_SCRIPTING,SCRIPT_HELP_Keyspecs,0,NULL,0)},
diff --git a/src/eval.c b/src/eval.c
index a0f515e5e9..d992af6a71 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -734,16 +734,11 @@ NULL
         dictEntry *de;
         luaScript *ls;
 
-        if (sdslen(c->argv[2]->ptr) != 40) {
-            addReplyError(c, "Sha1 length must be 40");
-            return;
-        }
-
         if ((de = dictFind(lctx.lua_scripts, c->argv[2]->ptr))) {
             ls = dictGetVal(de);
             addReplyBulk(c, ls->body);
         } else {
-            addReply(c, shared.null[c->resp]);
+            addReplyErrorObject(c, shared.noscripterr);
         }
     } else {
         addReplySubcommandSyntaxError(c);
diff --git a/src/server.c b/src/server.c
index 2853a23ac8..79f0d3cd89 100644
--- a/src/server.c
+++ b/src/server.c
@@ -1816,7 +1816,7 @@ void createSharedObjects(void) {
     shared.syntaxerr = createObject(OBJ_STRING, sdsnew("-ERR syntax error\r\n"));
     shared.sameobjecterr = createObject(OBJ_STRING, sdsnew("-ERR source and destination objects are the same\r\n"));
     shared.outofrangeerr = createObject(OBJ_STRING, sdsnew("-ERR index out of range\r\n"));
-    shared.noscripterr = createObject(OBJ_STRING, sdsnew("-NOSCRIPT No matching script. Please use EVAL.\r\n"));
+    shared.noscripterr = createObject(OBJ_STRING, sdsnew("-NOSCRIPT No matching script.\r\n"));
     createSharedObjectsWithCompat();
     shared.primarydownerr = createObject(
         OBJ_STRING, sdsnew("-MASTERDOWN Link with MASTER is down and replica-serve-stale-data is set to 'no'.\r\n"));
diff --git a/tests/unit/scripting.tcl b/tests/unit/scripting.tcl
index a09a2a1639..685dc274b1 100644
--- a/tests/unit/scripting.tcl
+++ b/tests/unit/scripting.tcl
@@ -639,13 +639,18 @@ start_server {tags {"scripting"}} {
     } {b534286061d4b9e4026607613b95c06c06015ae8 loaded}
 
     test {SCRIPT DUMP - is able to dump scripts from the scripting cache} {
-        list \
-            [r script dump b534286061d4b9e4026607613b95c06c06015ae8] \
-            [r script dump b534286061d4b9e4026607613b95c06c06015ae1]
-    } {{return 'loaded'} {}}
+        r script load "return 'dump'"
+        r script dump 4f5a49d7b18244a3b100d159b78b51474e23e081
+    } {return 'dump'}
+
+    test {SCRIPT DUMP - wrong sha1 length or invalid sha1 char return noscript error} {
+        assert_error {NOSCRIPT*} {r script dump b534286061d4b06c06015ae8}
+        assert_error {NOSCRIPT*} {r script dump AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA}
+    }
 
-    test {SCRIPT DUMP - wrong sha1 length} {
-        assert_error "ERR Sha1 length must be 40" {r script dump b534286061d4b06c06015ae8}
+    test {SCRIPT DUMP - scirpt not exist return noscript error} {
+        r script flush
+        assert_error {NOSCRIPT*} {r script dump 4f5a49d7b18244a3b100d159b78b51474e23e081}
     }
 
     test "SORT is normally not alpha re-ordered for the scripting engine" {

From 33f2f4205b43ffa4be14381569c130cb49dfec33 Mon Sep 17 00:00:00 2001
From: "wei.kukey" <wei.kukey@gmail.com>
Date: Wed, 12 Jun 2024 19:11:21 +0800
Subject: [PATCH 08/13] fix unit test spell wrong

Change-Id: I46624f43824a6d61b0f43c399a2b7c53e1258e3d
Signed-off-by: wei.kukey <wei.kukey@gmail.com>
---
 tests/unit/scripting.tcl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/unit/scripting.tcl b/tests/unit/scripting.tcl
index 685dc274b1..6a488f2a90 100644
--- a/tests/unit/scripting.tcl
+++ b/tests/unit/scripting.tcl
@@ -648,7 +648,7 @@ start_server {tags {"scripting"}} {
         assert_error {NOSCRIPT*} {r script dump AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA}
     }
 
-    test {SCRIPT DUMP - scirpt not exist return noscript error} {
+    test {SCRIPT DUMP - script not exist return noscript error} {
         r script flush
         assert_error {NOSCRIPT*} {r script dump 4f5a49d7b18244a3b100d159b78b51474e23e081}
     }

From ed3c62da9177c9fa58c8241810f628d2712ef8a4 Mon Sep 17 00:00:00 2001
From: "wei.kukey" <wei.kukey@gmail.com>
Date: Thu, 13 Jun 2024 14:06:59 +0800
Subject: [PATCH 09/13] fix reply schema and add fast path to return noscript
 err

Change-Id: Ia756dc5db4ebad5c83b4cc3b7f4a6702f94cfca4
Signed-off-by: wei.kukey <wei.kukey@gmail.com>
---
 src/commands/script-dump.json | 4 ++--
 src/eval.c                    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/commands/script-dump.json b/src/commands/script-dump.json
index a43cb0086d..a1ba0204e7 100644
--- a/src/commands/script-dump.json
+++ b/src/commands/script-dump.json
@@ -26,8 +26,8 @@
                     "type": "string"
                 },
                 {
-                    "description": "null if sha1 hash does not exist in script cache.",
-                    "type": "null"
+                    "description": "noscript error if sha1 hash does not exist in script cache.",
+                    "const": "NOSCRIPT No matching script."
                 }
             ]
         }
diff --git a/src/eval.c b/src/eval.c
index d992af6a71..1863569e09 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -734,7 +734,7 @@ NULL
         dictEntry *de;
         luaScript *ls;
 
-        if ((de = dictFind(lctx.lua_scripts, c->argv[2]->ptr))) {
+        if (sdslen(c->argv[2]->ptr) == 40 && (de = dictFind(lctx.lua_scripts, c->argv[2]->ptr))) {
             ls = dictGetVal(de);
             addReplyBulk(c, ls->body);
         } else {

From 24367eede50b102b1ed7788464bc43cfee0eba71 Mon Sep 17 00:00:00 2001
From: "wei.kukey" <wei.kukey@gmail.com>
Date: Sun, 16 Jun 2024 10:16:14 +0800
Subject: [PATCH 10/13] make script dump reply_schema clear

Change-Id: I2034e9523ee27f824e01b82920faf8c8b32fd3c9
Signed-off-by: wei.kukey <wei.kukey@gmail.com>
---
 src/commands/script-dump.json | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/src/commands/script-dump.json b/src/commands/script-dump.json
index a1ba0204e7..331be4d7c1 100644
--- a/src/commands/script-dump.json
+++ b/src/commands/script-dump.json
@@ -20,16 +20,8 @@
             }
         ],
         "reply_schema": {
-            "oneOf": [
-                {
-                    "description": "lua script if sha1 hash exists in script cache.",
-                    "type": "string"
-                },
-                {
-                    "description": "noscript error if sha1 hash does not exist in script cache.",
-                    "const": "NOSCRIPT No matching script."
-                }
-            ]
+            "description": "lua script if sha1 hash exists in script cache.",
+            "type": "string"
         }
     }
 }

From ac7f7c0607e4cba34055a3d73236447cfc326fe1 Mon Sep 17 00:00:00 2001
From: "wei.kukey" <wei.kukey@gmail.com>
Date: Tue, 18 Jun 2024 20:40:57 +0800
Subject: [PATCH 11/13] use script-show subcommand

Change-Id: Ieb1b35629728b269c270ea97d775b4c2542a755f
Signed-off-by: wei.kukey <wei.kukey@gmail.com>
---
 src/commands.def                              | 46 +++++++++----------
 .../{script-dump.json => script-show.json}    |  4 +-
 src/eval.c                                    |  6 +--
 tests/unit/scripting.tcl                      | 14 +++---
 4 files changed, 35 insertions(+), 35 deletions(-)
 rename src/commands/{script-dump.json => script-show.json} (88%)

diff --git a/src/commands.def b/src/commands.def
index 11a100ffbf..73ee731f3c 100644
--- a/src/commands.def
+++ b/src/commands.def
@@ -5210,28 +5210,6 @@ struct COMMAND_ARG SCRIPT_DEBUG_Args[] = {
 {MAKE_ARG("mode",ARG_TYPE_ONEOF,-1,NULL,NULL,NULL,CMD_ARG_NONE,3,NULL),.subargs=SCRIPT_DEBUG_mode_Subargs},
 };
 
-/********** SCRIPT DUMP ********************/
-
-#ifndef SKIP_CMD_HISTORY_TABLE
-/* SCRIPT DUMP history */
-#define SCRIPT_DUMP_History NULL
-#endif
-
-#ifndef SKIP_CMD_TIPS_TABLE
-/* SCRIPT DUMP tips */
-#define SCRIPT_DUMP_Tips NULL
-#endif
-
-#ifndef SKIP_CMD_KEY_SPECS_TABLE
-/* SCRIPT DUMP key specs */
-#define SCRIPT_DUMP_Keyspecs NULL
-#endif
-
-/* SCRIPT DUMP argument table */
-struct COMMAND_ARG SCRIPT_DUMP_Args[] = {
-{MAKE_ARG("sha1",ARG_TYPE_STRING,-1,NULL,NULL,NULL,CMD_ARG_NONE,0,NULL)},
-};
-
 /********** SCRIPT EXISTS ********************/
 
 #ifndef SKIP_CMD_HISTORY_TABLE
@@ -5352,15 +5330,37 @@ struct COMMAND_ARG SCRIPT_LOAD_Args[] = {
 {MAKE_ARG("script",ARG_TYPE_STRING,-1,NULL,NULL,NULL,CMD_ARG_NONE,0,NULL)},
 };
 
+/********** SCRIPT SHOW ********************/
+
+#ifndef SKIP_CMD_HISTORY_TABLE
+/* SCRIPT SHOW history */
+#define SCRIPT_SHOW_History NULL
+#endif
+
+#ifndef SKIP_CMD_TIPS_TABLE
+/* SCRIPT SHOW tips */
+#define SCRIPT_SHOW_Tips NULL
+#endif
+
+#ifndef SKIP_CMD_KEY_SPECS_TABLE
+/* SCRIPT SHOW key specs */
+#define SCRIPT_SHOW_Keyspecs NULL
+#endif
+
+/* SCRIPT SHOW argument table */
+struct COMMAND_ARG SCRIPT_SHOW_Args[] = {
+{MAKE_ARG("sha1",ARG_TYPE_STRING,-1,NULL,NULL,NULL,CMD_ARG_NONE,0,NULL)},
+};
+
 /* SCRIPT command table */
 struct COMMAND_STRUCT SCRIPT_Subcommands[] = {
 {MAKE_CMD("debug","Sets the debug mode of server-side Lua scripts.","O(1)","3.2.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_DEBUG_History,0,SCRIPT_DEBUG_Tips,0,scriptCommand,3,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_DEBUG_Keyspecs,0,NULL,1),.args=SCRIPT_DEBUG_Args},
-{MAKE_CMD("dump","Dump server-side Lua script in the script cache.","O(1).","8.0.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_DUMP_History,0,SCRIPT_DUMP_Tips,0,scriptCommand,3,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_DUMP_Keyspecs,0,NULL,1),.args=SCRIPT_DUMP_Args},
 {MAKE_CMD("exists","Determines whether server-side Lua scripts exist in the script cache.","O(N) with N being the number of scripts to check (so checking a single script is an O(1) operation).","2.6.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_EXISTS_History,0,SCRIPT_EXISTS_Tips,2,scriptCommand,-3,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_EXISTS_Keyspecs,0,NULL,1),.args=SCRIPT_EXISTS_Args},
 {MAKE_CMD("flush","Removes all server-side Lua scripts from the script cache.","O(N) with N being the number of scripts in cache","2.6.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_FLUSH_History,1,SCRIPT_FLUSH_Tips,2,scriptCommand,-2,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_FLUSH_Keyspecs,0,NULL,1),.args=SCRIPT_FLUSH_Args},
 {MAKE_CMD("help","Returns helpful text about the different subcommands.","O(1)","5.0.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_HELP_History,0,SCRIPT_HELP_Tips,0,scriptCommand,2,CMD_LOADING|CMD_STALE,ACL_CATEGORY_SCRIPTING,SCRIPT_HELP_Keyspecs,0,NULL,0)},
 {MAKE_CMD("kill","Terminates a server-side Lua script during execution.","O(1)","2.6.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_KILL_History,0,SCRIPT_KILL_Tips,2,scriptCommand,2,CMD_NOSCRIPT|CMD_ALLOW_BUSY,ACL_CATEGORY_SCRIPTING,SCRIPT_KILL_Keyspecs,0,NULL,0)},
 {MAKE_CMD("load","Loads a server-side Lua script to the script cache.","O(N) with N being the length in bytes of the script body.","2.6.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_LOAD_History,0,SCRIPT_LOAD_Tips,2,scriptCommand,3,CMD_NOSCRIPT|CMD_STALE,ACL_CATEGORY_SCRIPTING,SCRIPT_LOAD_Keyspecs,0,NULL,1),.args=SCRIPT_LOAD_Args},
+{MAKE_CMD("show","Show server-side lua script in the script cache.","O(1).","8.0.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_SHOW_History,0,SCRIPT_SHOW_Tips,0,scriptCommand,3,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_SHOW_Keyspecs,0,NULL,1),.args=SCRIPT_SHOW_Args},
 {0}
 };
 
diff --git a/src/commands/script-dump.json b/src/commands/script-show.json
similarity index 88%
rename from src/commands/script-dump.json
rename to src/commands/script-show.json
index 331be4d7c1..adc8fced98 100644
--- a/src/commands/script-dump.json
+++ b/src/commands/script-show.json
@@ -1,6 +1,6 @@
 {
-    "DUMP": {
-        "summary": "Dump server-side Lua script in the script cache.",
+    "SHOW": {
+        "summary": "Show server-side lua script in the script cache.",
         "complexity": "O(1).",
         "group": "scripting",
         "since": "8.0.0",
diff --git a/src/eval.c b/src/eval.c
index 1863569e09..c17594ad29 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -675,8 +675,8 @@ void scriptCommand(client *c) {
 "    Kill the currently executing Lua script.",
 "LOAD <script>",
 "    Load a script into the scripts cache without executing it.",
-"DUMP <sha1>",
-"    Dump a script from the scripts cache.",
+"SHOW <sha1>",
+"    Show a script from the scripts cache.",
 NULL
         };
         /* clang-format on */
@@ -730,7 +730,7 @@ NULL
             addReplyError(c, "Use SCRIPT DEBUG YES/SYNC/NO");
             return;
         }
-    } else if (c->argc == 3 && !strcasecmp(c->argv[1]->ptr, "dump")) {
+    } else if (c->argc == 3 && !strcasecmp(c->argv[1]->ptr, "show")) {
         dictEntry *de;
         luaScript *ls;
 
diff --git a/tests/unit/scripting.tcl b/tests/unit/scripting.tcl
index 6a488f2a90..58fae2c794 100644
--- a/tests/unit/scripting.tcl
+++ b/tests/unit/scripting.tcl
@@ -638,19 +638,19 @@ start_server {tags {"scripting"}} {
             [r evalsha b534286061d4b9e4026607613b95c06c06015ae8 0]
     } {b534286061d4b9e4026607613b95c06c06015ae8 loaded}
 
-    test {SCRIPT DUMP - is able to dump scripts from the scripting cache} {
+    test {SCRIPT SHOW - is able to dump scripts from the scripting cache} {
         r script load "return 'dump'"
-        r script dump 4f5a49d7b18244a3b100d159b78b51474e23e081
+        r script show 4f5a49d7b18244a3b100d159b78b51474e23e081
     } {return 'dump'}
 
-    test {SCRIPT DUMP - wrong sha1 length or invalid sha1 char return noscript error} {
-        assert_error {NOSCRIPT*} {r script dump b534286061d4b06c06015ae8}
-        assert_error {NOSCRIPT*} {r script dump AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA}
+    test {SCRIPT SHOW - wrong sha1 length or invalid sha1 char return noscript error} {
+        assert_error {NOSCRIPT*} {r script show b534286061d4b06c06015ae8}
+        assert_error {NOSCRIPT*} {r script show AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA}
     }
 
-    test {SCRIPT DUMP - script not exist return noscript error} {
+    test {SCRIPT SHOW - script not exist return noscript error} {
         r script flush
-        assert_error {NOSCRIPT*} {r script dump 4f5a49d7b18244a3b100d159b78b51474e23e081}
+        assert_error {NOSCRIPT*} {r script show 4f5a49d7b18244a3b100d159b78b51474e23e081}
     }
 
     test "SORT is normally not alpha re-ordered for the scripting engine" {

From 36de039f3de146f46229658491cc94e4699d1698 Mon Sep 17 00:00:00 2001
From: Madelyn Olson <madelyneolson@gmail.com>
Date: Tue, 18 Jun 2024 13:45:19 -0700
Subject: [PATCH 12/13] Apply suggestions from code review
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>

Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
---
 src/commands/script-show.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/commands/script-show.json b/src/commands/script-show.json
index adc8fced98..f22fa29675 100644
--- a/src/commands/script-show.json
+++ b/src/commands/script-show.json
@@ -1,6 +1,6 @@
 {
     "SHOW": {
-        "summary": "Show server-side lua script in the script cache.",
+        "summary": "Show server-side Lua script in the script cache.",
         "complexity": "O(1).",
         "group": "scripting",
         "since": "8.0.0",
@@ -20,7 +20,7 @@
             }
         ],
         "reply_schema": {
-            "description": "lua script if sha1 hash exists in script cache.",
+            "description": "Lua script if sha1 hash exists in script cache.",
             "type": "string"
         }
     }

From e8c0d1f814852ba83aaa23cda0e020569c82f866 Mon Sep 17 00:00:00 2001
From: Madelyn Olson <madelyneolson@gmail.com>
Date: Tue, 18 Jun 2024 13:46:09 -0700
Subject: [PATCH 13/13] Update src/commands.def

Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
---
 src/commands.def | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/commands.def b/src/commands.def
index 73ee731f3c..536d9fe4b1 100644
--- a/src/commands.def
+++ b/src/commands.def
@@ -5360,7 +5360,7 @@ struct COMMAND_STRUCT SCRIPT_Subcommands[] = {
 {MAKE_CMD("help","Returns helpful text about the different subcommands.","O(1)","5.0.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_HELP_History,0,SCRIPT_HELP_Tips,0,scriptCommand,2,CMD_LOADING|CMD_STALE,ACL_CATEGORY_SCRIPTING,SCRIPT_HELP_Keyspecs,0,NULL,0)},
 {MAKE_CMD("kill","Terminates a server-side Lua script during execution.","O(1)","2.6.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_KILL_History,0,SCRIPT_KILL_Tips,2,scriptCommand,2,CMD_NOSCRIPT|CMD_ALLOW_BUSY,ACL_CATEGORY_SCRIPTING,SCRIPT_KILL_Keyspecs,0,NULL,0)},
 {MAKE_CMD("load","Loads a server-side Lua script to the script cache.","O(N) with N being the length in bytes of the script body.","2.6.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_LOAD_History,0,SCRIPT_LOAD_Tips,2,scriptCommand,3,CMD_NOSCRIPT|CMD_STALE,ACL_CATEGORY_SCRIPTING,SCRIPT_LOAD_Keyspecs,0,NULL,1),.args=SCRIPT_LOAD_Args},
-{MAKE_CMD("show","Show server-side lua script in the script cache.","O(1).","8.0.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_SHOW_History,0,SCRIPT_SHOW_Tips,0,scriptCommand,3,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_SHOW_Keyspecs,0,NULL,1),.args=SCRIPT_SHOW_Args},
+{MAKE_CMD("show","Show server-side Lua script in the script cache.","O(1).","8.0.0",CMD_DOC_NONE,NULL,NULL,"scripting",COMMAND_GROUP_SCRIPTING,SCRIPT_SHOW_History,0,SCRIPT_SHOW_Tips,0,scriptCommand,3,CMD_NOSCRIPT,ACL_CATEGORY_SCRIPTING,SCRIPT_SHOW_Keyspecs,0,NULL,1),.args=SCRIPT_SHOW_Args},
 {0}
 };