Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dropdown): explicitly call markForCheck() #566

Merged
merged 1 commit into from
Jun 6, 2016
Merged

fix(dropdown): explicitly call markForCheck() #566

merged 1 commit into from
Jun 6, 2016

Conversation

andreialecu
Copy link
Contributor

Fixes #563

@andreialecu andreialecu mentioned this pull request May 31, 2016
Closed
@valorkin
Copy link
Member

valorkin commented Jun 2, 2016

Hey, thanks for PR. Have you tried dropdowns with other change detection strategies?

@andreialecu
Copy link
Contributor Author

I only tried CheckAlways (the default) and OnPush.

But all the other cases should be handled by this PR.

If you could make a new release with this it would be great, so I can change my dependencies back to the master here. :)

@valorkin
Copy link
Member

valorkin commented Jun 3, 2016

ok, I will do release today
with couple of modal fixes + new docs + and this one

@valorkin valorkin merged commit 0ce4328 into valor-software:development Jun 6, 2016
@slubowsky slubowsky mentioned this pull request Oct 28, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreialecu @valorkin