-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for zone.js error in Safari, Added Typings #221
Conversation
…fari, explicit call of NgZone not required in zone.js ^0.6.12
"del-cli": "0.2.0", | ||
"es6-promise": "3.1.2", | ||
"es6-shim": "0.35.0", | ||
"es7-reflect-metadata": "1.6.0", | ||
"eslint": "^2.10.2", |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Looks really good, please apply comment and rebase on top of dev branch PS are you using npm 2? |
Applied as suggested. @valorkin yes - currently we're working with npm 2. Therefore some of those "missing" packages are non-flat dependency related. |
Looks really good now! :) PS: no need to fix, but:
|
Thanks for merging @valorkin npm 3 is much better, indeed. But ionic2 currently sings better with node 4.x. Therefore, we are using its built-in package manager - and that's unfortunately npm 2. |
Is this fix already available? Because in my safari browser on my mac, the single file upload on this page is not working: http://valor-software.com/ng2-file-upload/ |
It should been fixed. Can you post the error message you're receiving? |
In Chrome it works ok. In safari on my mac, the progressbar is already 100% before I have clicked the upload button. This is the error I see in the console:
|
@ This polyfill should solve this issue: https://github.com/andyearnshaw/Intl.js/ Can you please open an issue for this @lderks? |
This PR contains the following changes:
More tasks executed then were scheduled
) in Safari by removingNgZone
fromFileItem
: Since zone.js 0.6.12, callbacks / observables are evaluated correctly in angular's zone by default. Therefore callingNgZone#run
is not necessary anymore.FileUploader
andFileItem
to include correct type specifications to check against in controllers that include ng2-file-upload