Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typeahead): added subscription and unsubscribe on destroy #2508

Merged
merged 1 commit into from
Aug 29, 2017

Conversation

krooshua
Copy link
Contributor

@krooshua krooshua commented Aug 24, 2017

#2382

Also fixed a bug, when navigating to another route before asyncActions() end.

TypeaheadContainerComponent.html:16 ERROR TypeError: Cannot read property 'insertNode' of undefined
    at TransitionAnimationEngine.webpackJsonp.../../../animations/@angular/animations/browser.es5.js.TransitionAnimationEngine.insertNode (browser.es5.js:3608)
    at InjectableAnimationEngine.webpackJsonp.../../../animations/@angular/animations/browser.es5.js.AnimationEngine.onInsert (browser.es5.js:4702)
    at AnimationRenderer.webpackJsonp.../../../platform-browser/@angular/platform-browser/animations.es5.js.BaseAnimationRenderer.insertBefore (animations.es5.js:387)
    at DebugRenderer2.webpackJsonp.../../../core/@angular/core.es5.js.DebugRenderer2.insertBefore (core.es5.js:13620)
    at execRenderNodeAction (core.es5.js:8886)
    at visitRenderNode (core.es5.js:8857)
    at visitSiblingRenderNodes (core.es5.js:8788)
    at visitRootRenderNodes (core.es5.js:8772)
    at renderAttachEmbeddedView (core.es5.js:9726)
    at attachEmbeddedView (core.es5.js:9606)

valor-software#2382

Also fixed bug, when navigating to other router before asyncActions() end.
@valorkin
Copy link
Member

Looks good to me

@valorkin valorkin merged commit 9f833eb into valor-software:development Aug 29, 2017
@valorkin valorkin added this to the v1.9.2 milestone Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants