Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(timepicker): remove inline styling, #2496 #2812

Merged
merged 8 commits into from
Oct 20, 2017
Merged

feat(timepicker): remove inline styling, #2496 #2812

merged 8 commits into from
Oct 20, 2017

Conversation

LimarenkoDenis
Copy link
Contributor

@LimarenkoDenis LimarenkoDenis commented Oct 6, 2017

#2496

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@LimarenkoDenis LimarenkoDenis changed the title feat(timepicker): remove inline styling, 2496 feat(timepicker): remove inline styling, #2496 Oct 6, 2017
@codecov
Copy link

codecov bot commented Oct 6, 2017

Codecov Report

Merging #2812 into development will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2812      +/-   ##
===============================================
+ Coverage        70.38%   70.69%   +0.31%     
===============================================
  Files              137      137              
  Lines             4092     4149      +57     
  Branches           711      731      +20     
===============================================
+ Hits              2880     2933      +53     
+ Misses             913      911       -2     
- Partials           299      305       +6
Impacted Files Coverage Δ
src/timepicker/timepicker.component.ts 91.42% <ø> (ø) ⬆️
src/typeahead/typeahead.directive.ts 71.8% <0%> (-0.09%) ⬇️
src/typeahead/typeahead-container.component.ts 79.83% <0%> (+6.98%) ⬆️
src/utils/utils.class.ts 80% <0%> (+30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eccb382...de87da6. Read the comment docs.

@IlyaSurmay
Copy link
Contributor

Hi!
If you simply remove inline styles from timepicker, it will cause this:
screenshot

So you should replace them with component-scoped styles. Please update your PR.
Thanks for PR!

Copy link
Contributor

@IlyaSurmay IlyaSurmay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline styles must be replaced with component-scoped styles

@LimarenkoDenis
Copy link
Contributor Author

Sorry for misunderstanding the issue, I updated pull request

@YevheniiaMazur
Copy link

Tested, looks good

@valorkin
Copy link
Member

@LimarenkoDenis thanks for the contribution! :)

@valorkin valorkin merged commit 417d0a2 into valor-software:development Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants