fix(typeahead): fix close on blur #2816

IlyaSurmay · 2017-10-09T10:45:27Z

read and followed the CONTRIBUTING.md guide.
built and tested the changes locally.
added/updated tests.

codecov · 2017-10-09T10:56:41Z

Codecov Report

Merging #2816 into development will decrease coverage by 0.03%.
The diff coverage is 42.85%.

@@               Coverage Diff               @@
##           development    #2816      +/-   ##
===============================================
- Coverage        70.48%   70.44%   -0.04%     
===============================================
  Files              137      137              
  Lines             4089     4094       +5     
  Branches           711      712       +1     
===============================================
+ Hits              2882     2884       +2     
- Misses             909      912       +3     
  Partials           298      298

Impacted Files	Coverage Δ
src/typeahead/typeahead.directive.ts	`71.89% <42.85%> (-0.89%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 934da3a...3b3e623. Read the comment docs.

src/typeahead/typeahead.directive.ts

@@ -276,6 +276,10 @@ export class TypeaheadDirective implements OnInit, OnDestroy {
        dropup: this.dropup
      });

+    this._outsideClickListener = this.renderer.listen('document', 'click', () => {


fix(typeahead): fix close on blur

d725bc7

IlyaSurmay added the comp(typeahead) label Oct 9, 2017

IlyaSurmay requested a review from valorkin October 9, 2017 10:45

Merge branch 'development' into fix-typeahead-click

3b3e623

valorkin reviewed Oct 9, 2017

View reviewed changes

IlyaSurmay added the needs review label Oct 9, 2017

valorkin merged commit 8bedcee into development Oct 10, 2017

valorkin added this to the v2.0.0 milestone Oct 10, 2017

valorkin added Hacktoberfest and removed needs review labels Oct 10, 2017

valorkin deleted the fix-typeahead-click branch October 10, 2017 00:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(typeahead): fix close on blur #2816

fix(typeahead): fix close on blur #2816

IlyaSurmay commented Oct 9, 2017 •

edited

Loading

codecov bot commented Oct 9, 2017 •

edited

Loading

This comment was marked as off-topic.

This comment was marked as off-topic.

fix(typeahead): fix close on blur #2816

fix(typeahead): fix close on blur #2816

Conversation

IlyaSurmay commented Oct 9, 2017 • edited Loading

codecov bot commented Oct 9, 2017 • edited Loading

Codecov Report

This comment was marked as off-topic.

This comment was marked as off-topic.

IlyaSurmay commented Oct 9, 2017 •

edited

Loading

codecov bot commented Oct 9, 2017 •

edited

Loading