Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2929 display date on init #2930

Conversation

grzegorz-jazurek
Copy link

I found out that Input interceptor for bsValue emit bsValueChange event before bs-datepicker-input.directive is initialised

this._picker.bsValueChange.subscribe((v: Date) => {

I used setTimeout to move execution at the end of stack.
I'm new in angular 4 so maybe you can use better solution, but main problem is defined above

@codecov
Copy link

codecov bot commented Oct 28, 2017

Codecov Report

Merging #2930 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           development   #2930   +/-   ##
===========================================
  Coverage         70.7%   70.7%           
===========================================
  Files              137     137           
  Lines             4165    4165           
  Branches           737     737           
===========================================
  Hits              2945    2945           
  Misses             914     914           
  Partials           306     306

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e3e456...0be3709. Read the comment docs.

@valorkin valorkin added this to the v2.0.0 milestone Nov 2, 2017
valorkin added a commit that referenced this pull request Nov 2, 2017
@valorkin
Copy link
Member

valorkin commented Nov 2, 2017

@grzegorz-jazurek thanks a lot for issue and PR!
fixed in a bit different way: #2962

valorkin added a commit that referenced this pull request Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datepicker don't display initial value in <input>
3 participants