Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alert): added isOpen input and marked as OnPush #2940

Merged
merged 3 commits into from
Nov 3, 2017

Conversation

valorkin
Copy link
Member

@valorkin valorkin commented Nov 1, 2017

todo:

  • add demo with switching dismissable property - DONE
  • add demo with dynamic content with binding to outside of alert value - DONE

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@valorkin valorkin added this to the v2.0.0 milestone Nov 1, 2017
@YevheniiaMazur
Copy link

Demo looks good. Needs test fixing:
screenshot from 2017-11-01 17-15-54

@codecov
Copy link

codecov bot commented Nov 3, 2017

Codecov Report

Merging #2940 into development will increase coverage by 0.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2940      +/-   ##
===============================================
+ Coverage        65.78%   65.79%   +0.01%     
===============================================
  Files              207      207              
  Lines             5606     5608       +2     
  Branches           983      983              
===============================================
+ Hits              3688     3690       +2     
  Misses            1656     1656              
  Partials           262      262
Impacted Files Coverage Δ
src/alert/alert.component.ts 89.65% <87.5%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e16efee...e7fd8e1. Read the comment docs.

@YevheniiaMazur
Copy link

Tested, looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants