Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add issuer names to resolution results #172

Merged
merged 1 commit into from
Mar 24, 2023
Merged

feat: add issuer names to resolution results #172

merged 1 commit into from
Mar 24, 2023

Conversation

silasbw
Copy link
Contributor

@silasbw silasbw commented Mar 24, 2023

Clients can surface this information to users (e.g., "send to 0xf00 on Kaala").

Clients can surface this information to users (e.g., "send to 0xf00 on Kaala").
@codecov-commenter
Copy link

Codecov Report

Merging #172 (2ed96ae) into main (16bfdca) will increase coverage by 0.05%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   92.50%   92.55%   +0.05%     
==========================================
  Files           5        5              
  Lines          80       94      +14     
  Branches        9       10       +1     
==========================================
+ Hits           74       87      +13     
- Misses          6        7       +1     
Impacted Files Coverage Δ
src/types.ts 100.00% <ø> (ø)
src/resolve-celo.ts 97.82% <94.11%> (-2.18%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16bfdca...2ed96ae. Read the comment docs.

Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

@silasbw silasbw merged commit 95654d7 into main Mar 24, 2023
@silasbw silasbw deleted the names0 branch March 24, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants